Set fixed Maestro appId across flows/ YAMLs for PR-visible coverage branch

[Copilot]

This updates the Maestro flow files so the testing-coverage PR branch uses a fixed app id (io.hexawallet.keeper) instead of environment-substituted ${APPID}. Scope is intentionally limited to flows/ to preserve all other existing PR changes.

• What changed

  • Replaced the top-level appId value in all flow YAMLs under flows/:
    • appId: ${APPID}
    • appId: io.hexawallet.keeper
  • Applied consistently across both existing and newly added Maestro scenarios on the branch.

• Scope constraints

  • No logic/step changes in flow commands.
  • No edits outside flows/.

• Example

# before
appId: ${APPID}
---
- tapOn:
    id: 'view_wallet_0'

# after
appId: io.hexawallet.keeper
---
- tapOn:
    id: 'view_wallet_0'

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• blackie.c3-soft.com
  • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js t@users.noreply.mkdir -p "Release/obj.target/" "./Release/.deps/Release/obj.target/" node /bit�� t_buffer.node git in/as get native.git (dns block)
  • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js /node node /bit�� (dns block)
• invalid.host
  • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js t@users.noreply.mkdir -p "Release/obj.target/" "./Release/.deps/Release/obj.target/" node /bit�� t_buffer.node git in/as get native.git (dns block)
• mempool.space
  • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js t@users.noreply.mkdir -p "Release/obj.target/" "./Release/.deps/Release/obj.target/" node /bit�� t_buffer.node git in/as get native.git (dns block)
  • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js /node node /bit�� (dns block)
• static.realm.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/.bin/prebuild-install --runtime napi er.o�� ite(sys.executab-I (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Create a pull request or update the existing PR branch context in KeeperCommunity/bitcoin-keeper so that all Maestro flow files under flows/ on branch copilot/update-maestro-testing-coverage use the fixed app id io.hexawallet.keeper instead of appId: ${APPID}. Keep the change limited to the flows/ folder and preserve the rest of the existing PR changes. The user specifically wants the same appId change reflected in the PR so it becomes visible there.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: @copilot Accepted Confirmation: Confirm agent session

Assistant: Done — I’ve initiated the replacement implementation request for the real Maestro overhaul on feat/openspec-integration, scoped exactly to the flows/ folder and aimed at the result you want:

• audit/fix existing Maestro YAMLs
• add happy-path + negative-path coverage
• improve Android/iOS compatibility where realistic
• avoid non-flows/ changes
• document missing coverage / Maestro-only limitations

Track progress here:
https://github.com/copilot/tasks/pull/PR_kwDOHBFs3s7aIWDK?session_id=7964f9a0-2a82-4212-9530-f20d1aa79019

data:
  - title: "[WIP] Add Maestro testing cases for Bitcoin Keeper app"
    repository: "KeeperCommunity/bitcoin-keeper"
    url: https://github.com/copilot/tasks/pull/PR_kwDOHBFs3s7aIWDK?session_id=7964f9a0-2a82-4212-9530-f20d1aa79019
    state: queued

Also, for clarity:

• PR Add composed Maestro core-journey flows for Bitcoin Keeper #6945 is not your final answer
• I’ve treated it as insufficient
• This new request is the one intended to produce the final Maestro suite you asked for

When the new PR appears, send me that PR link and I’ll do the final pass on:

1. exact flows covered,
2. happy vs negative-path coverage,
3. remaining missing coverage,
4. whether it’s actually ready to merge.

User: @KeeperCommunity/bitcoin-keeper/pull/6948

Assistant: PR #6948 is the stronger follow-up PR you asked for: it actually edits legacy flows in flows/, adds new happy/negative-path Maestro cases, and includes a coverage/limitations summary. It looks much closer to your real goal than #6945, though it is still a draft and should be reviewed before merge.

In a nutshell

This PR audits existing Maestro YAMLs, fixes several concrete bugs/flaky patterns, and adds new scenario files for both happy and negative paths. It also stays within flows/ only and includes a flows/COVERAGE.md file describing what is covered, what is still missing, and what Maestro alone cannot reliably automate.

Summary

Item	Value
PR	#6948
Title	Maestro flows: full audit, bug fixes, and happy/negative-path coverage expansion
Author	Copilot
State	open
Draft	true
Base branch	feat/openspec-integration
Head branch	copilot/update-maestro-testing-coverage
Commits	2
Files changed	21
Lines	+629 / -62
Comments	0
Reviews	0
Mergeable	true
Mergeable state	unstable
Scope compliance	Changes appear limited to flows/
Risk	medium — meaningful improvement, but still needs manual validation because many flows are stateful and UI/network dependent
CI status	Not available from the data I could retrieve in this pass

What this PR changes

Existing flow fixes

It modifies existing legacy flows to fix likely breakage/flakiness:

• flows/appsettings.yaml
• flows/buyBTC.yaml
• flows/copywalletaddress.yaml
• flows/exportseed.yaml
• flows/receive.yaml
• flows/send.yaml
• flows/setpin.yaml
• flows/subscription.yaml
• flows/viewwallet.yaml
• flows/walletSetting.yaml

New happy-path flows

• flows/appsettings_toggles.yaml
• flows/receive_address_display.yaml
• flows/regression_full.yaml

New negative-path flows

• flows/exportseed_wrong_pin.yaml
• flows/login_wrong_pin.yaml
• flows/send_cancel.yaml
• flows/send_empty_amount.yaml
• flows/send_invalid_address.yaml
• flows/setpin_mismatch.yaml
• flows/wallet_creation_cancel.yaml

Coverage documentation

• flows/COVERAGE.md

Strong points

This PR is much better aligned with your request because it:

• fixes known broken selectors and logic bugs
• adds negative-path coverage
• improves some flaky polling/wait behavior
• keeps all changes in flows/
• documents remaining gaps honestly

Most important concrete fixes

Selector bug fixes

Example:

-    id: 'btn_App_Backup}'
+    id: 'btn_App_Backup'

-    id: 'view_ KeeperTelegram'
+    id: 'view_KeeperTelegram'

These look like real correctness fixes.

Seed export passcode fix

</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

*This pull request was created from Copilot chat.*
>