Skip to content

Keep Server Settings warning below saved server list items#6953

Draft
Copilot wants to merge 6 commits into
feat/openspec-integrationfrom
copilot/fix-server-settings-text-overlap
Draft

Keep Server Settings warning below saved server list items#6953
Copilot wants to merge 6 commits into
feat/openspec-integrationfrom
copilot/fix-server-settings-text-overlap

Conversation

Copy link
Copy Markdown

Copilot AI commented May 11, 2026

The Server Settings screen could render the offline warning on top of the last saved Electrum server row, obscuring the Delete / Connect actions and breaking the layout. This change keeps the warning in the scroll flow so it renders after saved servers instead of overlapping them.

  • UI layout

    • Move the disconnected-state warning for non-empty server lists out of the fixed footer
    • Render that warning as FlatList footer content so it always appears after the last ServerItem
    • Preserve the existing empty-state behavior: when no saved servers exist, the warning still appears above the add-node action
  • Behavior kept intact

    • No changes to node connect / disconnect / delete flows
    • No changes to warning copy or add-node navigation
    • No store, persistence, or network logic changes
  • Focused coverage

    • Add a NodeSettings test covering:
      • warning renders in the list footer when saved servers exist and none is connected
      • empty-state warning remains outside the list footer when no servers exist
<FlatList
  data={nodeList}
  keyExtractor={(item) => item.id}
  ListFooterComponent={renderNodeListFooter}
/>

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • blackie.c3-soft.com
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js /home/REDACTED/.canode ./postinstall.js e -c e git ntry/cli/node_modules/.bin/sh arget/bigint_bufsh l/config odules/npm/node_patch-package e BUIL�� e build node_modules/.bin/as --local l/config ode_modules/bigi1,200p l/openssl/include (dns block)
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js h e -c e git de/node/bin/uname 14.1/include/nodsh l/config (dns block)
  • invalid.host
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js /home/REDACTED/.canode ./postinstall.js e -c e git ntry/cli/node_modules/.bin/sh arget/bigint_bufsh l/config odules/npm/node_patch-package e BUIL�� e build node_modules/.bin/as --local l/config ode_modules/bigi1,200p l/openssl/include (dns block)
  • mempool.space
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js /home/REDACTED/.canode ./postinstall.js e -c e git ntry/cli/node_modules/.bin/sh arget/bigint_bufsh l/config odules/npm/node_patch-package e BUIL�� e build node_modules/.bin/as --local l/config ode_modules/bigi1,200p l/openssl/include (dns block)
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/jest-worker/build/workers/processChild.js h e -c e git de/node/bin/uname 14.1/include/nodsh l/config (dns block)
  • static.realm.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/bitcoin-keeper/bitcoin-keeper/node_modules/.bin/prebuild-install --runtime napi ode_�� &#39;)); (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix text overlapping issue on server settings screen Keep Server Settings warning below saved server list items May 11, 2026
Copilot AI requested a review from cakesoft-shashank May 11, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server Settings screen text overlapping with server list item.

2 participants