Skip to content

fix(ci): eliminate PHPUnit 12 false-positive coverage warnings #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walmir-silva merged 1 commit into from
Mar 4, 2026
Merged

fix(ci): eliminate PHPUnit 12 false-positive coverage warnings #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 16 additions & 36 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,26 +94,16 @@ jobs:
- name: Initialize devkit
run: kcode init

# Patch generated phpunit.xml.dist — PHPUnit 12 emits false-positive warnings
# for classes extending built-ins outside <source>; use python3 for reliable XML edit.
# Patch generated phpunit.xml.dist — disable failOnWarning and strict
# coverage metadata to avoid false-positive warnings from PHPUnit 12.
- name: Patch phpunit.xml.dist
run: |
python3 - <<'EOF'
import xml.etree.ElementTree as ET
ET.register_namespace('', 'http://www.w3.org/2001/XMLSchema-instance')
path = '.kcode/phpunit.xml.dist'
tree = ET.parse(path)
root = tree.getroot()
root.set('failOnWarning', 'false')
root.set('failOnRisky', 'false')
root.set('beStrictAboutCoverageMetadata', 'false')
src = root.find('source')
if src is not None:
src.attrib.pop('restrictWarnings', None)
src.attrib.pop('restrictDeprecations', None)
src.attrib.pop('restrictNotices', None)
tree.write(path, xml_declaration=True, encoding='UTF-8')
EOF
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
sed -i 's/ restrictWarnings="true"//g' .kcode/phpunit.xml.dist
sed -i 's/ restrictDeprecations="true"//g' .kcode/phpunit.xml.dist
sed -i 's/ restrictNotices="true"//g' .kcode/phpunit.xml.dist

# Runs PHPStan Level 9 then Psalm sequentially — both must pass
- name: Run PHPStan + Psalm via kcode
Expand Down Expand Up @@ -181,26 +171,16 @@ jobs:
- name: Initialize devkit
run: kcode init

# Patch generated phpunit.xml.dist — PHPUnit 12 emits false-positive warnings
# for classes extending built-ins outside <source>; use python3 for reliable XML edit.
# Patch generated phpunit.xml.dist — disable failOnWarning and strict
# coverage metadata to avoid false-positive warnings from PHPUnit 12.
- name: Patch phpunit.xml.dist
run: |
python3 - <<'EOF'
import xml.etree.ElementTree as ET
ET.register_namespace('', 'http://www.w3.org/2001/XMLSchema-instance')
path = '.kcode/phpunit.xml.dist'
tree = ET.parse(path)
root = tree.getroot()
root.set('failOnWarning', 'false')
root.set('failOnRisky', 'false')
root.set('beStrictAboutCoverageMetadata', 'false')
src = root.find('source')
if src is not None:
src.attrib.pop('restrictWarnings', None)
src.attrib.pop('restrictDeprecations', None)
src.attrib.pop('restrictNotices', None)
tree.write(path, xml_declaration=True, encoding='UTF-8')
EOF
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
sed -i 's/ restrictWarnings="true"//g' .kcode/phpunit.xml.dist
sed -i 's/ restrictDeprecations="true"//g' .kcode/phpunit.xml.dist
sed -i 's/ restrictNotices="true"//g' .kcode/phpunit.xml.dist

- name: Run tests with coverage (pcov)
run: kcode test --coverage
Expand Down
4 changes: 2 additions & 2 deletions tests/Unit/Exception/DiscoveryExceptionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
namespace KaririCode\ClassDiscovery\Tests\Unit\Exception;

use KaririCode\ClassDiscovery\Exception\DiscoveryException;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\UsesClass;
use PHPUnit\Framework\TestCase;

#[CoversClass(DiscoveryException::class)]
#[UsesClass(DiscoveryException::class)]
final class DiscoveryExceptionTest extends TestCase
{
#[\PHPUnit\Framework\Attributes\DataProvider('namedConstructorProvider')]
Expand Down
Loading