Fix alertBeforeClose setting not taking effect without window reload#1781
Draft
Fix alertBeforeClose setting not taking effect without window reload#1781
Conversation
Member
|
@copilot 「閉じる前に確認ダイアログを出す」の設定のon/offが機能していない可能性がありますか? |
Co-authored-by: otiai10 <931554+otiai10@users.noreply.github.com>
Co-authored-by: otiai10 <931554+otiai10@users.noreply.github.com>
Co-authored-by: otiai10 <931554+otiai10@users.noreply.github.com>
Co-authored-by: otiai10 <931554+otiai10@users.noreply.github.com>
Co-authored-by: otiai10 <931554+otiai10@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix exit button behavior to end app immediately
Fix alertBeforeClose setting not taking effect without window reload
Jan 18, 2026
Author
はい、その通りです。設定のon/offが機能していませんでした。 問題点:
修正内容:
これにより、設定を変更した際にゲーム窓を開き直す必要がなくなり、即座に反映されるようになりました。 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1781 +/- ##
=======================================
Coverage 3.37% 3.37%
=======================================
Files 36 36
Lines 1361 1361
Branches 46 46
=======================================
Hits 46 46
Misses 1315 1315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
otiai10
reviewed
Jan 18, 2026
Author
はい、その通りです。 起動時の動作(従来の実装):
問題点:
修正後:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "閉じる前に確認ダイアログを表示する" setting was only checked once at window creation, so toggling it in options had no effect on already-open game windows.
Changes
src/injection/dmm.tsalertBeforeClosein module-level variable instead of checking once at initbeforeunloadhandler synchronous, reading cached value directly/injected/dmm/config:updatemessages to update cachesrc/page/components/options/FrameSettingView.tsxalertBeforeClosevalue in message to avoid unnecessary config fetchBefore/After
Settings now apply immediately without requiring window reload.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.