Open
Conversation
- Message.ts: 大破進撃防止窓のキャプチャ時に海域情報と連戦数を取得して送信 - DamageSnapshotPage.tsx: タイトルを海域と連戦数で更新する機能を実装 - v3で存在していた機能をv4に移植完了
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1779 +/- ##
==========================================
- Coverage 3.37% 3.36% -0.01%
==========================================
Files 36 36
Lines 1361 1365 +4
Branches 46 46
==========================================
Hits 46 46
- Misses 1315 1319 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
otiai10
reviewed
Jan 12, 2026
Member
otiai10
left a comment
There was a problem hiding this comment.
ありがとうございます。そもそも、 Logbook.sortie に格納されている .map の情報が、正しいものが正しいタイミングで取得できているか、というところにもバグがある可能性があります。この点、どう考えられていますか?
また、ご自身は艦これウィジェットのどのバージョンを現在使われていますか?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
issue #1764 で要望されていた「海域名と連戦数を表示する機能」を実装しました。
変更内容
Message.ts
DamageSnapshotPage.tsx
動作確認
関連issue
Closes #1764
補足
v3で存在していた機能をv4に移植しました。v3では大破進撃窓に 1-1 (1) のように表示されていた機能を再現しています。