Open
Conversation
riki7649255
requested changes
Sep 22, 2024
Collaborator
riki7649255
left a comment
riki7649255
left a comment
There was a problem hiding this comment.
DB/NEW_KT_DB/DataAccess/DBClusterParameterGroupManager.py
- self.object_manager.create_management_table(...) => add pk_column... = 'TEXT' and not just send 'TEXT'
- remove empty lines from end of file
DB/NEW_KT_DB/DataAccess/ObjectManager.py
3. rename is_exists() to is_object_exist()
DB/NEW_KT_DB/Service/Classes/DBClusterParameterGroupService.py
4. remove commented code
- you did not use custom exceptions. why?
- I dont see validations why?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.