tamar_k_parametergroup

[saraNoigershel]

No description provided.

[riki7649255]

DB/NEW_KT_DB/DataAccess/DBClusterParameterGroupManager.py:

1. rename table_schema to table_structure
2. line 37- remove empty lines

DB/NEW_KT_DB/Service/Classes/DBClusterParameterGroupService.py
3. rename function camel_to_snake_case() to convert_camel_case_string_to_snake()
4. rename function convert_dict_keys_to_snake_case() to convert_dict_keys_from_camel_case_to_snake()

DB/NEW_KT_DB/Test/DBClusterParameterGroupTests.py
5. remove commented code and other dev leftobers if exist
6. I see you used multiple times the variables group_name, file_name, and few more. it is better to put the usefull static variables inside init() method of your test class, and the dynamic variables inside internal function that will change the value assigned in the init() method too.

DB/NEW_KT_DB/Test/GeneralTests.py
7. this file should contain general tests only, or internal functions. so the function def delete_file_if_exists(storage_manager, file_name): you created suppose to be in the storage.object_manager.

[riki7649255]

DB/NEW_KT_DB/Test/DBClusterParameterGroupTests.py

1. I see you used multiple times the variables group_name, file_name, and few more. it is better to put the usefull static variables inside init() method of your test class, and the dynamic variables inside internal function that will change the value assigned in the init() method too.