Open
Conversation
riki7649255
requested changes
Sep 18, 2024
Collaborator
riki7649255
left a comment
There was a problem hiding this comment.
DB/ELTS/.ipynb_checkpoints/Untitled-checkpoint.ipynb
- ignore file- don't push it
DB/ELTS/Untitled.ipynb
2. ignore file
- are you the owner of cluster & instance both? if not, did you sync with cluster owner? she knows you touched her files?
DB/NEW_KT_DB/Controller/DBSubnetGroupController.py
4. you are not the owner of subnet group, why did you push the whole file?
please fix your pr- you can create new one only with your files and send for me to review
Collaborator
Author
|
1, 2 - נכון, אני אמחק
3. אני אחראית על cluster - ומשתמשת בתוכו ב Instance - אז אני צריכה את שתי
המחלקות כדי להריץ, ובאמת כדאי שאני אמחק אותם ממני למקרה שהיא שינתה עוד
משהו...
4.נכון, מוחקת
עשיתי את השינויים
אשמח לאישור
בתאריך יום ד׳, 18 בספט׳ 2024 ב-22:16 מאת riki7649255 <
***@***.***>:
… ***@***.**** requested changes on this pull request.
DB/ELTS/.ipynb_checkpoints/Untitled-checkpoint.ipynb
1. ignore file- don't push it
DB/ELTS/Untitled.ipynb
2. ignore file
3. are you the owner of cluster & instance both? if not, did you sync
with cluster owner? she knows you touched her files?
DB/NEW_KT_DB/Controller/DBSubnetGroupController.py
4. you are not the owner of subnet group, why did you push the whole file?
please fix your pr- you can create new one only with your files and send
for me to review
—
Reply to this email directly, view it on GitHub
<#334 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE6TF6YS5IC7AIPIULJNEXLZXHGRNAVCNFSM6AAAAABONWFZPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJTGU2TOOJSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.