Conversation
riki7649255
left a comment
There was a problem hiding this comment.
DB/NEW_KT_DB/Controller/DBSnapshotController.py-
- you kept the cluster function names, please adjust to snapshot
DB/NEW_KT_DB/DataAccess/DBManager.py:
2. please ignore all changes in this file since we gonna push the changes once and for all, so lets try to avoid unneeded conflicts
DB/NEW_KT_DB/DataAccess/DBSnapshotManager.py:
3. in init()- remove the self.table_name assignment, we dont need it- we use generic convention for management tabl name based on class name
DB/NEW_KT_DB/DataAccess/ObjectManager.py:
4. same as #2- ignore all changes
DB/NEW_KT_DB/Service/Classes/DBSnapshotService.py:
- documentation only in English, please trunslate.
- add some basic validations
- you dont need the conn & cursor- thats where NEW_KT_DB.ObjectManager comes in use. or DBManager- you should not access the db directly from here
please change it all and resent for review
good luck
riki7649255
left a comment
There was a problem hiding this comment.
DB/NEW_KT_DB/DataAccess/DBSnapshotManager.py
- self.create_table() => did you run it? what function it calls to? I dont see inside your manager create_table function, and I should not. you should call the object_manager.create_management_table()
DB/NEW_KT_DB/Models/DBSnapshotModel.py
2. you need to define the object_name attribute inside the init() method, and it will be good to define table_structure too.
DB/NEW_KT_DB/Service/Classes/DBSnapshotService.py
3. you still have Hebrew text
riki7649255
left a comment
There was a problem hiding this comment.
rename all snapshot files from snapshot to NaiveSnapshot
riki7649255
left a comment
There was a problem hiding this comment.
- I told you to add Naive after Snapshot- rename DBSnapshotControllerNaive to DBSnapshotNaiveController, and for all files also.
- discard changes DB/NEW_KT_DB/DataAccess/DBManager.py
- discard changes DB/NEW_KT_DB/DataAccess/ObjectManager.py
- DB/NEW_KT_DB/Validation/DBClusterValiditions.py- why did you touch this file? its not yours
No description provided.