Skip to content

Create the base of the class#305

Open
leah-bellahsen-git wants to merge 8 commits intomainfrom
create-snapshot-class
Open

Create the base of the class#305
leah-bellahsen-git wants to merge 8 commits intomainfrom
create-snapshot-class

Conversation

@leah-bellahsen-git
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@riki7649255 riki7649255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB/NEW_KT_DB/Controller/DBSnapshotController.py-

  1. you kept the cluster function names, please adjust to snapshot

DB/NEW_KT_DB/DataAccess/DBManager.py:
2. please ignore all changes in this file since we gonna push the changes once and for all, so lets try to avoid unneeded conflicts

DB/NEW_KT_DB/DataAccess/DBSnapshotManager.py:
3. in init()- remove the self.table_name assignment, we dont need it- we use generic convention for management tabl name based on class name

DB/NEW_KT_DB/DataAccess/ObjectManager.py:
4. same as #2- ignore all changes

DB/NEW_KT_DB/Service/Classes/DBSnapshotService.py:

  1. documentation only in English, please trunslate.
  2. add some basic validations
  3. you dont need the conn & cursor- thats where NEW_KT_DB.ObjectManager comes in use. or DBManager- you should not access the db directly from here

please change it all and resent for review
good luck

Copy link
Copy Markdown
Collaborator

@riki7649255 riki7649255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB/NEW_KT_DB/DataAccess/DBSnapshotManager.py

  1. self.create_table() => did you run it? what function it calls to? I dont see inside your manager create_table function, and I should not. you should call the object_manager.create_management_table()

DB/NEW_KT_DB/Models/DBSnapshotModel.py
2. you need to define the object_name attribute inside the init() method, and it will be good to define table_structure too.

DB/NEW_KT_DB/Service/Classes/DBSnapshotService.py
3. you still have Hebrew text

Copy link
Copy Markdown
Collaborator

@riki7649255 riki7649255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename all snapshot files from snapshot to NaiveSnapshot

Copy link
Copy Markdown
Collaborator

@riki7649255 riki7649255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I told you to add Naive after Snapshot- rename DBSnapshotControllerNaive to DBSnapshotNaiveController, and for all files also.
  2. discard changes DB/NEW_KT_DB/DataAccess/DBManager.py
  3. discard changes DB/NEW_KT_DB/DataAccess/ObjectManager.py
  4. DB/NEW_KT_DB/Validation/DBClusterValiditions.py- why did you touch this file? its not yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants