-
Notifications
You must be signed in to change notification settings - Fork 1
match with netfri and without #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0219e8d
3b8375a
67c8b04
633731f
57bd790
532c0aa
52ddb9d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,7 +6,13 @@ WORKDIR /app | |||||||||||||||
| # ARG USE_NETFREE=true | ||||||||||||||||
|
|
||||||||||||||||
| RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates curl && rm -rf /var/lib/apt/lists/* | ||||||||||||||||
| COPY certs /app/certs | ||||||||||||||||
| RUN if [ -d certs ]; then \ | ||||||||||||||||
| echo "Copying certs directory..."; \ | ||||||||||||||||
| tar -cf - certs | tar -xf -; \ | ||||||||||||||||
| else \ | ||||||||||||||||
| echo "No certs directory, skipping copy."; \ | ||||||||||||||||
| fi | ||||||||||||||||
|
Comment on lines
+9
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Same issue - Replace with:
Suggested change
|
||||||||||||||||
|
|
||||||||||||||||
| # System CA + add NetFree certs | ||||||||||||||||
| RUN if [ "$USE_NETFREE" = "true" ] && [ -d ./certs ] && [ "$(ls ./certs/*.crt 2>/dev/null)" ]; then \ | ||||||||||||||||
| echo "Configuring NetFree certificates..."; \ | ||||||||||||||||
|
|
||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,7 +6,13 @@ WORKDIR /app | |||||||||||||||
| ARG USE_NETFREE=true | ||||||||||||||||
|
|
||||||||||||||||
| RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates curl && rm -rf /var/lib/apt/lists/* | ||||||||||||||||
| COPY certs /app/certs | ||||||||||||||||
| RUN if [ -d certs ]; then \ | ||||||||||||||||
| echo "Copying certs directory..."; \ | ||||||||||||||||
| tar -cf - certs | tar -xf -; \ | ||||||||||||||||
| else \ | ||||||||||||||||
| echo "No certs directory, skipping copy."; \ | ||||||||||||||||
| fi | ||||||||||||||||
|
Comment on lines
+9
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Same issue - Replace with:
Suggested change
|
||||||||||||||||
|
|
||||||||||||||||
| # System CA + add NetFree certs | ||||||||||||||||
| RUN if [ "$USE_NETFREE" = "true" ] && [ -d ./certs ] && [ "$(ls ./certs/*.crt 2>/dev/null)" ]; then \ | ||||||||||||||||
| echo "Configuring NetFree certificates..."; \ | ||||||||||||||||
|
|
||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,14 +4,24 @@ WORKDIR /app | |||||||||||||||
|
|
||||||||||||||||
| COPY requirements.txt . | ||||||||||||||||
|
|
||||||||||||||||
| COPY certs /app/certs | ||||||||||||||||
|
|
||||||||||||||||
| RUN apt-get update && \ | ||||||||||||||||
| apt-get install -y ca-certificates && \ | ||||||||||||||||
| cp /app/certs/*.crt /usr/local/share/ca-certificates/ && \ | ||||||||||||||||
| update-ca-certificates && \ | ||||||||||||||||
| apt-get clean && \ | ||||||||||||||||
| rm -rf /var/lib/apt/lists/* | ||||||||||||||||
| RUN if [ -d certs ]; then \ | ||||||||||||||||
| echo "Copying certs directory..."; \ | ||||||||||||||||
| tar -cf - certs | tar -xf -; \ | ||||||||||||||||
| else \ | ||||||||||||||||
| echo "No certs directory, skipping copy."; \ | ||||||||||||||||
| fi | ||||||||||||||||
|
Comment on lines
+7
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Replace with:
Suggested change
|
||||||||||||||||
|
|
||||||||||||||||
|
|
||||||||||||||||
| RUN apt-get update && apt-get install -y ca-certificates && \ | ||||||||||||||||
| if [ "$USE_NETFREE" = "true" ] && [ -d ./certs ] && [ "$(ls ./certs/*.crt 2>/dev/null)" ]; then \ | ||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Add before line 15: |
||||||||||||||||
| echo "Configuring NetFree certificates..."; \ | ||||||||||||||||
| cp ./certs/*.crt /usr/local/share/ca-certificates/; \ | ||||||||||||||||
| update-ca-certificates; \ | ||||||||||||||||
| else \ | ||||||||||||||||
| echo "Skipping certificate configuration (USE_NETFREE=$USE_NETFREE)"; \ | ||||||||||||||||
| fi && \ | ||||||||||||||||
| apt-get clean && rm -rf /var/lib/apt/lists/* | ||||||||||||||||
|
|
||||||||||||||||
|
|
||||||||||||||||
| ENV REQUESTS_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt | ||||||||||||||||
| ENV SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt | ||||||||||||||||
|
|
||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,7 +2,13 @@ FROM flink:1.20.0-scala_2.12-java11 | |||||||||||||||
| USER root | ||||||||||||||||
|
|
||||||||||||||||
| # Copy certs dir (may be empty) and trust *.crt if present | ||||||||||||||||
| COPY certs/ /tmp/certs/ | ||||||||||||||||
| RUN if [ -d certs ]; then \ | ||||||||||||||||
| echo "Copying certs directory..."; \ | ||||||||||||||||
| tar -cf - certs | tar -xf -; \ | ||||||||||||||||
| else \ | ||||||||||||||||
| echo "No certs directory, skipping copy."; \ | ||||||||||||||||
| fi | ||||||||||||||||
|
Comment on lines
+5
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Line 15 checks Replace with:
Suggested change
|
||||||||||||||||
|
|
||||||||||||||||
|
|
||||||||||||||||
| RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates curl && \ | ||||||||||||||||
| rm -rf /var/lib/apt/lists/* && \ | ||||||||||||||||
|
|
||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic:
RUNcannot access build context -certsdirectory doesn't exist in container yet. Thetaroperation will fail and no certs will be available for line 32.Replace with:
Or use a build arg to make the
COPYconditional before the build.