Open
Conversation
nemoguigrat
reviewed
Apr 27, 2025
| private final TodoService todoService; | ||
|
|
||
| @GetMapping("/get") | ||
| public List<TodoDto> getAllTodo() { |
There was a problem hiding this comment.
TaskDto используется как для ответа, так и для запроса. В данном случае не принципиально, но лучше для ответа и запроса (даже если в разных методах используется) создавать свои ДТО
| @NoArgsConstructor | ||
| @Entity | ||
| @Table(name = "todo") | ||
| public class TodoEntity { |
There was a problem hiding this comment.
У всех entity необходимо переопределять hashCode и equalse методы
|
|
||
| @Transactional(readOnly = true) | ||
| public List<TodoDto> findAll() { | ||
| return todoEntityRepository.findAll().stream() |
There was a problem hiding this comment.
Получим проблему n+1, на каждый Task будет выполнен запрос на поиск events, хотя все это можно загрузить за один запрос
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Студент: Аптуликсанов Руслан Германович
Преподаватель: Никита Иванов
createTodo):getAllTodo):todoи автогенерируемойevents)