Skip to content

Fail fast when a test container does not start #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaliCZ merged 2 commits into from
May 28, 2026
Merged

Fail fast when a test container does not start #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eebe906
Fail fast when a test container does not start
KaliCZ May 28, 2026
f72b4d0
Lower container start timeout to 45s
KaliCZ May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/StrongTypes.Api.IntegrationTests/Infrastructure/TestWebApplicationFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using DotNet.Testcontainers.Containers;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Mvc.Testing;
using Microsoft.Extensions.Configuration;
Expand All @@ -19,6 +20,8 @@ public sealed class TestWebApplicationFactory : WebApplicationFactory<Program>,
private const string DockerGroupLabel = "com.docker.compose.project";
private const string DockerGroupName = "StrongTypes";

private static readonly TimeSpan ContainerStartTimeout = TimeSpan.FromSeconds(45);

private readonly MsSqlContainer _sqlContainer = new MsSqlBuilder()
.WithLabel(DockerGroupLabel, DockerGroupName)
.Build();
Expand All @@ -31,7 +34,9 @@ async ValueTask IAsyncLifetime.InitializeAsync()
{
// Start both containers in parallel; containers must be up before the
// host is built so that ConfigureAppConfiguration can read their connection strings.
await Task.WhenAll(_sqlContainer.StartAsync(), _pgContainer.StartAsync());
await Task.WhenAll(
StartContainerAsync(_sqlContainer, "SQL Server"),
StartContainerAsync(_pgContainer, "PostgreSQL"));

// Accessing Services triggers the lazy host build.
using var scope = Services.CreateScope();
Expand All @@ -40,6 +45,22 @@ async ValueTask IAsyncLifetime.InitializeAsync()
await sp.GetRequiredService<PostgreSqlDbContext>().Database.EnsureCreatedAsync();
}

private static async Task StartContainerAsync(IContainer container, string name)
{
using var cts = new CancellationTokenSource(ContainerStartTimeout);
try
{
await container.StartAsync(cts.Token);
}
catch (OperationCanceledException) when (cts.IsCancellationRequested)
{
throw new TimeoutException(
$"The {name} test container did not start within {ContainerStartTimeout.TotalSeconds:0}s. " +
"It either failed to start or never began accepting connections — check the container logs. " +
"On ARM64 hosts this can also happen when the image has no native ARM build, as the emulated process may crash on startup.");
}
}

protected override void ConfigureWebHost(IWebHostBuilder builder)
{
builder.ConfigureAppConfiguration((_, config) =>
Expand Down
Loading