Add audio context file #1
Conversation
snuggs
left a comment
snuggs
left a comment
There was a problem hiding this comment.
A few nits. Looking good.
Adds bindings for `submit`, `formdata`, `change`, & `input` form events. Perhaps missing `cancel`?
|
@KageJordan please review 👉 fd4422f |
|
|
||
| <fieldset> | ||
|
|
||
| <legend hidden>Checkboxes</legend> |
There was a problem hiding this comment.
When you figure out a better legend text you want to keep that content by making it "invisible" not hidden (read comments). Fine for now to yank it out the dom but remember for later. Ultimately there should be no hiddens unless controlled by javascript. But fine to use during development. Just remember to remove before going live, like console.logs.
There was a problem hiding this comment.
Sounds good ,I hadn't thought about using display:none.Gracias
| <legend hidden>Checkboxes</legend> | ||
|
|
||
| <label> | ||
| <input name=pads type="checkbox"> |
There was a problem hiding this comment.
Interesting if you can make a convention around the value=.... Perhaps some convention like value=thunder then can use js to retrieve value and load thunder.mp3 or new ThunderCompressor etc.
| <input name=pads type="checkbox"> | ||
| </label> | ||
|
|
||
| </fieldset> |
There was a problem hiding this comment.
Triple closing </fieldset>s on the same nesting level? 🤔
There was a problem hiding this comment.
It should be one < fieldset> with 4 nesting < fieldset>s within , might have created too many spaces between tags, could be confusing.
Removed content from second <header > Reordered content in <input > elements
snuggs
left a comment
snuggs
left a comment
There was a problem hiding this comment.
Pretty good. Basically splitting html hairs at this point.
| <body> | ||
|
|
||
| <header> | ||
| <h1>DevPunks Sequencer</h1> |
There was a problem hiding this comment.
Off by 1 (whitespace) error? 😉
2 participants
No description provided.