fix(ci): build Docker images on PRs, push only on main#10
Merged
Conversation
Removes the job-level `if: github.ref == 'refs/heads/main'` guard from all six build-and-push jobs. The Docker build now runs on every PR so a broken Dockerfile is caught before merge. The GHCR login and push remain conditional on main so no credentials are needed during PR builds. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: github.ref == 'refs/heads/main'from all 6build-and-pushjobsmain(no credentials needed on PRs)Why
PRs #7 and #8 were both emergency fixes for Dockerfiles that only broke after merge. This change catches that class of failure on the PR itself.
Test plan
Build & Push Dockerjobs appear in this PR's checks🤖 Generated with Claude Code