Fix deadlock in BatchSamplerShard with drop_last=True#1
Open
Conversation
…h samplers without __len__ This fix addresses issue huggingface#3814 where deadlocks could occur when using custom batch samplers (generators) with drop_last=True in multi-process scenarios. Changes: - Added logic to determine last_batch_idx from batch sampler, handling cases where batch sampler doesn't have __len__ (set last_batch_idx = -1) - Added immediate yield logic when drop_last=True and either: 1. Batch sampler doesn't have __len__ (generator-based), OR 2. At last batch and it's incomplete Also added test_batch_sampler_with_drop_last_no_len() to verify the fix works correctly with custom batch samplers that don't have __len__.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses issue huggingface#3814 where deadlocks could occur when using custom batch samplers (generators) with drop_last=True in multi-process scenarios.