You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this PR I add functionality to define option data over any set. for example, to apply an emission limit and a capacity constraint to the same scenario data, you can define data like so:
While this bypasses the error described in issue #85, I am a little confused on how logic of handling data that is not defined over all sets (ie. AnnualEmissionLimit does not have an associated year in the provided example in the issue ticket). @HauHe was this just a mistake? Im not sure where to look to see if AnnualEmissionLimit is being applied correctly. I would suggest explicitly defining the year.
Thanks a lot @trevorb1!
I will have a look at it tomorrow.
If I remember correctly I had left the year here on purpose, but I'm not 100% sure anymore what behaviour I expected when applying the data. Has been some time since I wrote the code. I'll let you know
Hi @trevorb1 ,
sorry for the long silence, was a bit difficult to find the time to work on this.
In the original version of OSeMOSYS_step, I had written some code that allowed to instead of providing a series of values for each year in the options, to provide a single value that could be either absolute or a percentage, indicated via the %-symbol. This only worked if the parameter was already defined in the step before, if not an error was produced. I think this feature is very useful since it allows to have changes in parameters over the modelling time horizon without having jumps, since you are indicating the change of the parameter an not the absolute value.
I think it would be great if we could reintroduce this feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I add functionality to define option data over any set. for example, to apply an emission limit and a capacity constraint to the same scenario data, you can define data like so:
While this bypasses the error described in issue #85, I am a little confused on how logic of handling data that is not defined over all sets (ie.
AnnualEmissionLimitdoes not have an associated year in the provided example in the issue ticket). @HauHe was this just a mistake? Im not sure where to look to see ifAnnualEmissionLimitis being applied correctly. I would suggest explicitly defining the year.