Skip to content

Fix the max burn time calculation for unequal-density fuel mixtures #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamalmostafa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the max burn time calculation for unequal-density fuel mixtures #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/BetterBurnTime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,15 @@ private void GetThrustInfo(
for (int propellantIndex = 0; propellantIndex < engine.propellants.Count; ++propellantIndex)
{
Propellant propellant = engine.propellants[propellantIndex];
double density = PartResourceLibrary.Instance.GetDefinition(propellant.name).density;
if (!ShouldIgnore(propellant.name))
{
if (!availableResources.Has(propellant.name))
{
isStarved = true;
break;
}
ratioSum += propellant.ratio;
ratioSum += propellant.ratio * density;
}
}
if (isStarved) continue;
Expand All @@ -333,9 +334,10 @@ private void GetThrustInfo(
for (int propellantIndex = 0; propellantIndex < engine.propellants.Count; ++propellantIndex)
{
Propellant propellant = engine.propellants[propellantIndex];
double density = PartResourceLibrary.Instance.GetDefinition(propellant.name).density;
if (!ShouldIgnore(propellant.name))
{
double consumptionRate = ratio * propellant.ratio * engineTotalFuelConsumption; // tons/sec
double consumptionRate = ratio * propellant.ratio * density * engineTotalFuelConsumption; // tons/sec
propellantsConsumed.Add(propellant.name, consumptionRate);
}
}
Expand Down