Tests

[kvlaskarolina]

cd backend
pytest printing/tests/printing/processing/test_pages.py --cov
pytest printing/tests/printing/processing/test_imposition.py --cov
pytest printing/tests/printing/processing/test_final_pages.py --cov
pytest printing/tests/printing/processing/test_converter.py --cov

[piotr-3-janiszewski]

I think your tests are great! The code isn't hard to read, both the structure and naming makes sense. I personally (might be totally wrong, but I) think that there are many places in your code where adding a fixture might enable you to cover more edge cases without much effort. Great job 🥇 🎆 💯 👍 🏆

[piotr-3-janiszewski]

Maybe we could add more edge cases? For example a square page? Or a very long page?

[piotr-3-janiszewski]

The following two tests could be merged into one with a fixture and could cover more edge cases. Like being a square.

[dominik-korsa]

I agree, it's worth testing the page size utility functions on different sizes, especially covering the cases:

• width/height < 1/2
• width/height = 1/2
• width/height > 1/2, < 1
• width/height = 1
• width/height > 1, < 2
• width/height = 2
• width/height > 2
  The first and last case are especially confusing and thus error-prone, because splitting such pages along either edge does not change the page orientation. Make sure to test the page splitting utilities as well.

[dominik-korsa]

See the comments for some quick notes, please also wait for #154 to get merged to main an update this branch afterwards, since the changes from #154 are relevant to this PR

[dominik-korsa]

.coverage files should be ignored, this has been done in #154

[dominik-korsa]

I agree, it's worth testing the page size utility functions on different sizes, especially covering the cases:

• width/height < 1/2
• width/height = 1/2
• width/height > 1/2, < 1
• width/height = 1
• width/height > 1, < 2
• width/height = 2
• width/height > 2
  The first and last case are especially confusing and thus error-prone, because splitting such pages along either edge does not change the page orientation. Make sure to test the page splitting utilities as well.