Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion src/com/walking/lesson40_queue2/Main.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
package com.walking.lesson40_queue2;

import com.walking.lesson40_queue2.model.Task;
import com.walking.lesson40_queue2.service.TaskService;

import java.util.ArrayList;
import java.util.List;

/**
* Реализуйте класс Задание. Он должен содержать поле Название,
* состав остальных полей - на ваше усмотрение.
Expand All @@ -15,5 +21,36 @@
*/
public class Main {
public static void main(String[] args) {
TaskService taskService = new TaskService(getTaskList());

taskService.acceptSingleTask(new Task("Fourth"));
taskService.executeSingleTask();

if (taskService.haveTask()) {
taskService.cancelNextTask();
}

taskService.executeMultipleTasks(2);
taskService.acceptAllTasks(getTaskList());

List<Task> canceledTasks = taskService.cancelMultipleTasks(2);
System.out.println("Canceled tasks:");

for (Task canceledTask : canceledTasks) {
System.out.println(canceledTask.getName());
}

Task nextTask = taskService.lookNextTask();
System.out.println("Next task: " + nextTask.getName());
}

public static List<Task> getTaskList() {
List<Task> tasks = new ArrayList<>();

tasks.add(new Task("First"));
tasks.add(new Task("Second"));
tasks.add(new Task("Third"));

return tasks;
}
}
}
13 changes: 13 additions & 0 deletions src/com/walking/lesson40_queue2/model/Task.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package com.walking.lesson40_queue2.model;

public class Task {
private final String name;

public Task(String name) {
this.name = name;
}

public String getName() {
return name;
}
}
12 changes: 12 additions & 0 deletions src/com/walking/lesson40_queue2/model/TaskStatus.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.walking.lesson40_queue2.model;

public enum TaskStatus {
ACCEPTED,
EXECUTED,
CANCELED;

@Override
public String toString() {
return this.name().toLowerCase();
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

на будущее - для такого логичнее строковое поле завести. Ибо ключи енама менять зачастую проблематично - особенно, если они в бд храняться. А вот поле можно в любом удобном виде перекручивать, в зависимости от нужд бизнеса

Даже если изначально эти значения взаимовыводимы

}
}
103 changes: 103 additions & 0 deletions src/com/walking/lesson40_queue2/service/TaskService.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
package com.walking.lesson40_queue2.service;

import com.walking.lesson40_queue2.model.Task;
import com.walking.lesson40_queue2.model.TaskStatus;
import com.walking.lesson40_queue2.util.Logger;

import java.util.*;

public class TaskService {
private final Queue<Task> tasks;
private final Logger logger;

public TaskService() {
this.tasks = new ArrayDeque<>();
this.logger = new Logger();
}

public TaskService(Collection<? extends Task> incomingTasks) {
this.tasks = new ArrayDeque<>(incomingTasks);
this.logger = new Logger();

for (Task incomingTask : incomingTasks) {
logger.log(getTaskStatusMessage(incomingTask, TaskStatus.ACCEPTED));
}
}

public List<Task> getAllTasks() {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У тебя Task содержится в названии класса. Нет нужды дублировать это слово в каждом методе

return List.copyOf(tasks);
}

public boolean acceptSingleTask(Task acceptedTask) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Про Task написал выше. То, что он тут single - понятно из сигнатуры метода:)

if (tasks.offer(acceptedTask)) {
logger.log(getTaskStatusMessage(acceptedTask, TaskStatus.ACCEPTED));
return true;
}

return false;
}

public boolean acceptAllTasks(Collection<? extends Task> incomingTasks) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все же Many, а не All. Я понимаю, что тут ассоциация с addAll у коллекций могла сыграть. Но коллекции и бизнес-логика - они в чутка разных мирах живут:)

Вполне хватило бы перегрузки под accept() или acceptMany(). Я предпочитаю последний вариант, но это вкусовщина. acceptAll() - тоже имеет право на жизнь, но выглядит крайне непривычно

if (tasks.addAll(incomingTasks)) {
for (Task acceptedTask : incomingTasks) {
logger.log(getTaskStatusMessage(acceptedTask, TaskStatus.ACCEPTED));
}

return true;
}

return false;
}

public Task executeSingleTask() {
Task executedTask = tasks.poll();

if (executedTask != null) {
logger.log(getTaskStatusMessage(executedTask, TaskStatus.EXECUTED));
}

return executedTask;
}

public List<Task> executeMultipleTasks(int taskCount) {
List<Task> executedTasks = new ArrayList<>();

for (int i = 0; i < taskCount; i++) {
executedTasks.add(executeSingleTask());
}

return executedTasks;
}

public Task cancelNextTask() {
Task canceledTask = tasks.poll();

if (canceledTask != null) {
logger.log(getTaskStatusMessage(canceledTask, TaskStatus.CANCELED));
}

return canceledTask;
}

public List<Task> cancelMultipleTasks(int taskCount) {
List<Task> canceledTasks = new ArrayList<>();

for (int i = 0; i < taskCount; i++) {
canceledTasks.add(cancelNextTask());
}

return canceledTasks;
}

public Task lookNextTask() {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и зачем на него смотреть?) Обычно getNext()

return tasks.peek();
}

public boolean haveTask() {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

скорее has. Опять же, мб hasNext

return tasks.peek() != null;
}

private String getTaskStatusMessage(Task task, TaskStatus status) {
return "Task <%s> %s".formatted(task.getName(), status);
}
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в целом, нормальное решение. Но очень перегруженный нейминг методов

7 changes: 7 additions & 0 deletions src/com/walking/lesson40_queue2/util/Logger.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.walking.lesson40_queue2.util;

public class Logger {
public void log(String message) {
System.out.println(message);
}
}