Skip to content

Revert "Ui responsive for mobile"#7

Merged
utkarsh232005 merged 1 commit into
mainfrom
revert-5-responsive-ui
May 26, 2026
Merged

Revert "Ui responsive for mobile"#7
utkarsh232005 merged 1 commit into
mainfrom
revert-5-responsive-ui

Conversation

@utkarsh232005
Copy link
Copy Markdown
Member

@utkarsh232005 utkarsh232005 commented May 26, 2026

Reverts #5

Summary by CodeRabbit

Release Notes

  • Style

    • Streamlined navigation interface by simplifying the mobile menu
    • Updated component grid layouts and typography sizing for consistency
    • Adjusted spacing and minimum height values across components
  • Chores

    • Removed internal build patches and simplified build configuration

Review Change Stack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
kdm-website Building Building Preview, Comment May 26, 2026 7:28am

@utkarsh232005 utkarsh232005 merged commit 6e61ea7 into main May 26, 2026
3 of 7 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 064e3bc6-9971-478f-9e9a-b74b4d70888b

📥 Commits

Reviewing files that changed from the base of the PR and between 0036b67 and b6a123f.

📒 Files selected for processing (7)
  • package.json
  • scripts/patch-lovable-config.cjs
  • src/components/Commands.tsx
  • src/components/Hero.tsx
  • src/components/Navbar.tsx
  • src/components/Terminal.tsx
  • vite.config.ts

📝 Walkthrough

Walkthrough

The PR removes the postinstall script and its associated patch utility, simplifies Vite configuration, consolidates navbar navigation by eliminating mobile-specific hamburger menu logic, and standardizes component layout and typography across Commands, Hero, and Terminal UI elements with fixed sizing instead of responsive breakpoints.

Changes

UI styling and build configuration simplification

Layer / File(s) Summary
Build and deployment configuration cleanup
package.json, vite.config.ts
scripts.postinstall removed from package.json; vite.config.ts simplified to use boolean !isVercel for cloudflare plugin instead of conditional object. Associated patch script (scripts/patch-lovable-config.cjs) completely removed.
Navbar mobile and desktop consolidation
src/components/Navbar.tsx
Icon import updated to remove Menu, keeping only Star. GitHub "Star us" action refactored from mobile hamburger menu and desktop-only link into a single unified anchor link without responsive gating.
Component layout and sizing standardization
src/components/Commands.tsx, src/components/Hero.tsx, src/components/Terminal.tsx
Commands list removes horizontal overflow and button minimum height; Hero metrics grid changes to fixed three-column layout with consistent text-3xl sizing; Terminal container uses fixed min-h-[360px] instead of responsive breakpoint.

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • KDM-cli/kdm-website#5: Touches the same build hooks, component styling locations, and vite config but makes opposing changes to those implementations.

Poem

🐰 Hopping through the config with glee,
We simplify, we clean, we see,
No more patches, no mobile menu fuss,
Fixed layouts and styles for all of us!
A tidier site from top to ground! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-5-responsive-ui

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant