Skip to content

Favicon and footer addition#11

Open
Yuvraj-Sarathe wants to merge 2 commits into
KDM-cli:mainfrom
Yuvraj-Sarathe:favicon
Open

Favicon and footer addition#11
Yuvraj-Sarathe wants to merge 2 commits into
KDM-cli:mainfrom
Yuvraj-Sarathe:favicon

Conversation

@Yuvraj-Sarathe
Copy link
Copy Markdown
Member

@Yuvraj-Sarathe Yuvraj-Sarathe commented May 26, 2026

Solves issue #6

Summary by CodeRabbit

  • New Features
    • Privacy Policy page added and linked from the footer.
    • Terms of Service page added and linked from the footer.
    • Favicon added site-wide.
    • Footer navigation updated: privacy/terms use internal routing; status/GitHub open external links.

Review Change Stack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

@Yuvraj-Sarathe is attempting to deploy a commit to the utkarsh232005's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 912dfd68-1ae2-4af6-91cf-bf0139a4f8b4

📥 Commits

Reviewing files that changed from the base of the PR and between ce45b28 and 6217696.

📒 Files selected for processing (1)
  • src/components/Footer.tsx

📝 Walkthrough

Walkthrough

Adds two new static policy pages (/privacy, /terms) registered as TanStack Router file routes, updates the generated route tree, replaces Footer placeholder links with routed links and external anchors, and adds a favicon link to the root route head.

Changes

Privacy and Terms Pages

Layer / File(s) Summary
Create Privacy and Terms Page Routes
src/routes/privacy.tsx, src/routes/terms.tsx
Two new file routes create /privacy and /terms pages via createFileRoute, each composing Navbar, static policy content, Footer, and head metadata (title, description).
Register Routes in Generated Route Tree
src/routeTree.gen.ts
Generated route tree imports the new route modules, instantiates PrivacyRoute and TermsRoute, extends exported route-type interfaces and @tanstack/react-router augmentation, and adds the routes to rootRouteChildren.
Update Footer Navigation and Root Favicon
src/components/Footer.tsx, src/routes/__root.tsx
Footer imports Link and replaces placeholder anchors with routed links for Privacy and Terms and updates external GitHub/Status anchors; root route imports logoUrl and adds a favicon <link> in head metadata.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • utkarsh232005

Poem

🐰 Two new pages hop into view,
Privacy and Terms, both shiny and new,
Footer links now point the way true,
A favicon sparkles in the head too,
A little rabbit cheers—hip hop, woo!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions favicon and footer, but the changeset includes two new pages (/privacy and /terms), route tree updates, and navbar footer link changes — making the title incomplete and not reflective of the main scope. Consider a more comprehensive title like 'Add privacy/terms pages, favicon, and update footer navigation' to better reflect all substantial changes in the changeset.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

codescene-delta-analysis[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/Footer.tsx`:
- Around line 19-26: The Status anchor tag in Footer.tsx has a typo in its href
("https://github.com/KDM-cli/kdm-clim"); update the href to the correct
repository name ("kdm-cli") so the link points to
"https://github.com/KDM-cli/kdm-cli". Locate the <a> element whose link text is
"Status" (the anchor with className "hover:text-foreground/40
transition-colors") and modify its href string accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ba50b3b0-6828-45fb-b1ad-4df4468c3257

📥 Commits

Reviewing files that changed from the base of the PR and between 9ff3b35 and ce45b28.

⛔ Files ignored due to path filters (1)
  • src/assets/logo.png is excluded by !**/*.png
📒 Files selected for processing (5)
  • src/components/Footer.tsx
  • src/routeTree.gen.ts
  • src/routes/__root.tsx
  • src/routes/privacy.tsx
  • src/routes/terms.tsx

Comment thread src/components/Footer.tsx
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Copy Markdown

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant