PR to update README - Workarounds for MacOS xterm, Docker build issue, and root access#13
Open
schnorea wants to merge 2 commits into
Open
PR to update README - Workarounds for MacOS xterm, Docker build issue, and root access#13schnorea wants to merge 2 commits into
schnorea wants to merge 2 commits into
Conversation
jockebech
reviewed
Nov 24, 2023
Collaborator
jockebech
left a comment
jockebech
left a comment
There was a problem hiding this comment.
Just a few minor comments, thanks!
|
|
||
| ### Additional Xterm Help | ||
| Once you run the docker run command above and are at the '/home/optee/qemu-optee' | ||
| command line, you run the `./launch_optee.sh` script and you get an error about |
Collaborator
There was a problem hiding this comment.
What about changing this from
script and you get an error about not being able to find the xterm (xQuartz) server that looks like this
to
script, you might get an error on MacOS saying something about not being able to find the xterm (xQuarts), like this:
I think that makes it clear that this is a MacOS issue and not normally seen on Linux.
| xterm: Xt error: Can't open display: /private/tmp/com.apple.launchd.CuNDWxl9fm/org.xquartz:0 | ||
| xterm: Xt error: Can't open display: /private/tmp/com.apple.launchd.CuNDWxl9fm/org.xquartz:0 | ||
| ``` | ||
| you don't need to restart the container to fix it. First, press CNTRL-c. |
Collaborator
There was a problem hiding this comment.
Add If that happens, , before the "you don't need ..."
Comment on lines
+64
to
+65
| this conversation | ||
| https://gist.github.com/cschiewek/246a244ba23da8b9f0e7b11a68bf3285?permalink_comment_id=3477013#gistcomment-3477013 |
Collaborator
There was a problem hiding this comment.
Suggested change
| this conversation | |
| https://gist.github.com/cschiewek/246a244ba23da8b9f0e7b11a68bf3285?permalink_comment_id=3477013#gistcomment-3477013 | |
| [this](https://gist.github.com/cschiewek/246a244ba23da8b9f0e7b11a68bf3285?permalink_comment_id=3477013#gistcomment-3477013) conversation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the README to provide work arounds for a few things I ran into.
MacOS xterm issue when env DISPLAY isn't set properly (might work on other OS assuming that the Xterm server is on the host of the docker container).
I found myself rebuilding the docker image when trying stuff out. It would fail because a change in the in the package repo was being overlook as the
apt-get updatewas cached.Root access, added how to work around getting root as I saw someone else asking.