Add note labels style dropdown (Alphabetic / Syllabic)#2
Conversation
Justagwas
left a comment
There was a problem hiding this comment.
Thanks for the contribution, the alphabetic/syllabic toggle is something I can get behind.
That said, I do not think this is ready to merge as implemented. C4, A0, etc. follow the standard scientific pitch notation. Changing them to forms like C⁴ introduces a custom display convention that is neither standard SPN nor Helmholtz notation, so it makes the labels less conventional without adding much value. For a standard 88-key piano, the relevant pitch range here is A0 through C8, and I do not think we should deviate from that notation in the UI.
There is also a practical UI issue with the syllabic labels, as they are wider than the current ones, and so, on black keys, they don't fit as well.
I'd support keeping the style toggle, but I think this needs some refinement before merge.
Summary
and Syllabic (Do, Re, Mi...) note naming styles
Changes
keymap.py: NewNoteNameStyletype alias, splitNOTE_NAMESintoALPHA_NOTE_NAMES/SYLLAB_NOTE_NAMES, addedOCTAVE_INDEXES` for superscript notationsettings_store.py: Newnote_name_stylesetting with load/save/validationmain_window.py: Style dropdown (ChevronComboBox) wired to a newnoteNameStyleChangedsignalpiano_widget.py:set_note_labels()method to refresh labels dynamicallyapp_controller.py: Connects everything, reacts to style changes, regenerates labels, persists thesetting