Skip to content

Add note labels style dropdown (Alphabetic / Syllabic)#2

Open
mevouc wants to merge 1 commit into
Justagwas:mainfrom
mevouc:feature/syllabic-note-labels
Open

Add note labels style dropdown (Alphabetic / Syllabic)#2
mevouc wants to merge 1 commit into
Justagwas:mainfrom
mevouc:feature/syllabic-note-labels

Conversation

@mevouc
Copy link
Copy Markdown

@mevouc mevouc commented Apr 1, 2026

Summary

  • Adds a dropdown next to the "Show note labels" checkbox to switch between Alphabetic (C, D, E...)
    and Syllabic (Do, Re, Mi...) note naming styles
  • The selected style is persisted in the user config and updates labels in real time
  • Octave numbers now use superscript Unicode characters for a cleaner look (e.g. C⁴ instead of C4)

Changes

  • keymap.py: New NoteNameStyletype alias, splitNOTE_NAMESintoALPHA_NOTE_NAMES/SYLLAB_NOTE_NAMES, added OCTAVE_INDEXES` for superscript notation
  • settings_store.py: New note_name_style setting with load/save/validation
  • main_window.py: Style dropdown (ChevronComboBox) wired to a new noteNameStyleChanged signal
  • piano_widget.py: set_note_labels() method to refresh labels dynamically
  • app_controller.py: Connects everything, reacts to style changes, regenerates labels, persists the
    setting

@mevouc mevouc requested a review from Justagwas as a code owner April 1, 2026 13:56
Copy link
Copy Markdown
Owner

@Justagwas Justagwas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, the alphabetic/syllabic toggle is something I can get behind.

That said, I do not think this is ready to merge as implemented. C4, A0, etc. follow the standard scientific pitch notation. Changing them to forms like C⁴ introduces a custom display convention that is neither standard SPN nor Helmholtz notation, so it makes the labels less conventional without adding much value. For a standard 88-key piano, the relevant pitch range here is A0 through C8, and I do not think we should deviate from that notation in the UI.

There is also a practical UI issue with the syllabic labels, as they are wider than the current ones, and so, on black keys, they don't fit as well.

I'd support keeping the style toggle, but I think this needs some refinement before merge.

@Justagwas Justagwas added the enhancement New feature or request label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants