-
Notifications
You must be signed in to change notification settings - Fork 48
synchronizing main (for deployment) #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properly setting container name using jobs instead of steps typo... stuff... trying example... stuff... stuff... removing plus
- removing uncessary requirements.txt passing arguements to hugo binary using pipenv to run commands setting working directory fixing based on PR #317
pinning deps based on container
- re-organizing GH actions
properly specifying container changing copying command
testing if can access service container testing if can access service container should be working now? trying to run in container only overriding user to be root chown for "dubious ownership" during report uplload changing ownership before tests in case failure
- verbose docker build
- need containers to be built first
- adding xdist - removing uncessary pause - removing all initial goto's - fixing flaky test_dropdown test testing
- specifying user to drop privs in makefile - ignoreing dockerfile & tests for docker builds
- used so we can use local Dockerfiles
- slight modificaiton for changing environment name
Add Fleet config folder to gitignore
- This should increase the size of the topics in the JB footer - This should close #245
- change `is-6` to `is-size-5` across topics
This increases the heading size of topic in footer
…upiterbroadcasting.com into feature/automate-sponsors-page
Deploy Previews and URL Encoding Tags
E2E GH Action - patch/modifying
Removal of the link to ease maintenance as the link may change (already has) and instead point folks to the main repo page under Environments.......
Feature/automate sponsors page
CGBassPlayer
approved these changes
Oct 25, 2022
Collaborator
CGBassPlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Footer change is present on the preview and all test passed locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
design and visual
enhancement
New feature, enhancement, or request
piece of 🍰
simple and uncomplicated to resolve.
QA
quality assurance (automated testing with playwright)
UX
related to user experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploying the following PRs to main:
Deploy preview for the current develop is accessible via this. I still don't know why render's deploy previews aren't working for PRs like #470...but till we figure it out we can't halt our current deployment system.