-
Notifications
You must be signed in to change notification settings - Fork 48
Add feedback blocks to episode pages #136 WIP #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
duckunix
wants to merge
1
commit into
JupiterBroadcasting:develop
Choose a base branch
from
duckunix:feature/136-feeback-button
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| <div class="level"> | ||
|
|
||
| <a class="link level-item pr-3" target="_blank" href="{{ (.GetPage `subscribe.md`).Permalink }}" title="subscribe"> | ||
| <div class="title fa fa-bell-ringing-o fa-3x"><span class="sr-only">subscribe</span></div> | ||
| </a> | ||
| <a class="link level-item pr-3" target="_blank" href="{{ (.GetPage `/membership`).Permalink }}" title="support"> | ||
| <div class="title fa fa-usd fa-3x"><span class="sr-only">support</span></div> | ||
| </a> | ||
| {{with .Params.links}} | ||
| {{ range $key, $value := . }} | ||
| <a class="link level-item pr-3" target="_blank" href="{{$value}}" title="{{$key}}"> | ||
| {{ if eq $key "email" }} | ||
| <div class="title fa fa-envelope fa-3x center"><span class="sr-only">{{$key}}</span></div> | ||
| {{ else if eq $key "shownotes" }} | ||
| <div class="title fa fa-pencil-square fa-3x"><span class="sr-only">{{$key}}</span></div> | ||
| {{ else if eq $key "matrix" }} | ||
| <div class="title fa fa-matrix-org fa-3x"><span class="sr-only">{{$key}}</span></div> | ||
| {{ else if eq $key "mumble" }} | ||
| <div class="title fa fa-headphones fa-3x"><span class="sr-only">{{$key}}</span></div> | ||
| {{ else if eq $key "discord" }} | ||
| <div class="title fa fa-{{$key}} fa-3x"><span class="sr-only">{{$key}}</span></div> | ||
| {{ else if eq $key "wiki" }} | ||
| <div class="title fa fa-book fa-3x"><span class="sr-only">{{$key}}</span></div> | ||
| {{ else if eq $key "blog" }} | ||
| <div class="title fa fa-paragraph fa-3x"><span class="sr-only">{{$key}}</span></div> | ||
| {{ else }} | ||
| <div class="title fa fa-{{$key}}-square fa-3x"><span class="sr-only">{{$key}}</span></div> | ||
| {{ end }} | ||
| </a> | ||
| {{ end }} | ||
| {{end}} | ||
| </div> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, there's actually a really nice construct (
.Parent) in Hugo that allows you to "traverse" up the file tree, so you can access files/parameters from parent files. So, adding that here would allow you to get access to all the links that the parent show has.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was what I was missing. :)
With that bit of knowledge, I think I can get the separate version worked out, then on to looking at DRY, which I am all for (a good SA is a Lazy SA and reuses whenever possible :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I now have the extra file working. Time to refactor down to one file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🥳