vrouter-agent: fix crash when XMPP port is unspec #751
Conversation
If one omits XMPP port in CONTROL-NODE.servers parameter in the vrouter-agent config file, the program would crash because it expects it to be always present. The parser doesn't enforce this, however. Fix by making XMPP port optional and defaulting to XMPP_SERVER_PORT (5269) where appropriate. Signed-off-by: Valentine Sinitsyn <valentine.sinitsyn@gmail.com>
|
Please, resubmit your change through gerrit: https://review.opencontrail.org/ |
|
Contrail/Tungsten Fabric does not accept GitHub pull requests. All changes should be submitted via the Gerrit code review tool. If you're not familiar with Gerrit, take a look at section 4 of https://github.com/tungstenfabric/docs/blob/master/Contributor/GettingStarted/getting-started-with-opencontrail-development.md for more info. The key points are that you need to login to https://review.opencontrail.org with an Ubuntu One account in order to establish your SSH public key. You need to clone the repos from Gerrit rather than (or in addition to) GitHub (or manually add an additional remote to an existing repo rather than cloning if you prefer). And you need to install and use the "git review" extension to Git in order to push changes to Gerrit. |
3 participants
If one omits XMPP port in CONTROL-NODE.servers parameter in the
vrouter-agent config file, the program would crash because it expects
it to be always present. The parser doesn't enforce this, however.
Fix by making XMPP port optional and defaulting to XMPP_SERVER_PORT
(5269) where appropriate.
Signed-off-by: Valentine Sinitsyn valentine.sinitsyn@gmail.com