Skip to content

Filtering the empty strings from substring array #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RohitPingale wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Filtering the empty strings from substring array #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b724a2
Filtering the empty strings from substring array
RohitPingale Oct 11, 2019
cc6f76f
Removing the Empty string from array
RohitPingale Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/sentences/sentence_splitting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ function rulebased_split_sentences(sentences)
sentences = replace(sentences, r"([?!.])\s" => Base.SubstitutionString("\\1\n"))

sentences = postproc_splits(sentences)
split(sentences, "\n")
split(sentences, "\n"; keepempty=false)
end



function replace_til_no_change(input, pattern, replacement)
while(occursin(pattern, input))
input = replace(input, pattern => replacement)
Expand Down Expand Up @@ -38,7 +37,6 @@ function postproc_splits(sentences::AbstractString)
# Before we do anything remove windows line-ends
sentences = replace(sentences, "\r" => "")


# breaks sometimes missing after "?", "safe" cases
sentences = replace(sentences, r"\b([a-z]+\?) ([A-Z][a-z]+)\b" => Base.SubstitutionString("\\1\n\\2"))
# breaks sometimes missing after "." separated with extra space, "safe" cases
Expand Down