Conditionally use Base.JuliaSyntax on newer Julia; keep vendored JuliaSyntax for older support#177
Draft
Copilot wants to merge 3 commits into
Draft
Conditionally use Base.JuliaSyntax on newer Julia; keep vendored JuliaSyntax for older support#177Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: ericphanson <5846501+ericphanson@users.noreply.github.com>
Co-authored-by: ericphanson <5846501+ericphanson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix nightly failure in test for inspect_session
Conditionally use Base.JuliaSyntax on newer Julia; keep vendored JuliaSyntax for older support
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly started failing in
inspect_sessionbecause the vendored JuliaSyntax parser rejects syntax now accepted/produced in newer Julia versions. This change switches parser backend by Julia version so newer Julia usesBase.JuliaSyntax, while older supported Julia continues using the vendored copy.Backend selection
src/ExplicitImports.jl:VERSION >= v"1.12.0-DEV.0"→ useBase.JuliaSyntaxVendored.JuliaSyntaxJuliaSyntaxbinding so downstream parsing logic remains unchanged.Vendoring behavior
AbstractTreesas before.Regression coverage
test/runtests.jlto assert:Base.JuliaSyntaxandVendored.JuliaSyntaxis not definedVendored.JuliaSyntaxWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/JuliaCollections/DataStructures.jl/tarball/e357641bb3e0638d353c4b29ea0e40ea644066a6/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaCollections/OrderedCollections.jl/tarball/05868e21324cede2207c6f0f466b4bfef6d5e7ee/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaCollections/SortingAlgorithms.jl/tarball/64d974c2e6fdf07f8155b5b2ca2ffa9069b608d9/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaData/DataAPI.jl/tarball/abe83f3a2f1b857aac70ef8b269080af17764bbe/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaData/DataFrames.jl/tarball/d8928e9169ff76c6281f39a659f9bca3a573f24c/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaData/InvertedIndices.jl/tarball/6da3c4316095de0f5ee2ebd875df8721e7e0bdbe/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaData/Missings.jl/tarball/ec4f7fbeab05d7747bdf98eb74d130a2a2ed298d/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaData/PooledArrays.jl/tarball/36d8b4b899628fb92c2749eb488d884a926614d3/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaData/SentinelArrays.jl/tarball/ebe7e59b37c400f694f52b58c93d26201387da70/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaData/Tables.jl/tarball/f2c1efbc8f3a609aadf318094f8fc5204bdaf344/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaLang/Compat.jl/tarball/9d8a54ce4b17aa5bdce0ea5c34bc5e7c340d16ad/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaLang/PrecompileTools.jl/tarball/07a921781cab75691315adc645096ed5e370cb77/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaPackaging/Preferences.jl/tarball/8b770b60760d4451834fe79dd483e318eee709c4/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaStats/Statistics.jl/tarball/ae3bb1eb3bba077cd276bc5cfc337cc65c3075c0/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaStrings/InlineStrings.jl/tarball/8f3d257792a522b4601c24a577954b0a8cd7334d/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaStrings/LaTeXStrings.jl/tarball/dda21b8cbd6a6c40d9d02a73230f9d70fed6918c/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaTesting/Aqua.jl/tarball/d57fd255a8932b6509baf43284c416fc44d0b903/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaTesting/MetaTesting.jl/tarball/fdd09ae407b46f83aaaadc8a839d5ef090929762/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/KristofferC/Crayons.jl/tarball/249fe38abf76d48563e2f4556bebd215aa317e15/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/queryverse/DataValueInterfaces.jl/tarball/bfc1187b79289637fa0ef6d4436ebdfe6905cbd6/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/queryverse/IteratorInterfaceExtensions.jl/tarball/a3f24677c21f5bbe9d2a714f95dcd58337fb2856/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/queryverse/TableTraits.jl/tarball/c06b2f539df1c6efa794486abfb6ed2022561a39/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/ronisbr/PrettyTables.jl/tarball/211530a7dc76ab59087f4d4d1fc3f086fbe87594/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/ronisbr/StringManipulation.jl/tarball/d05693d339e37d6ab134c5ab53c29fce5ee5d7d5/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/simonster/Reexport.jl/tarball/45e428421666073eab6f2da5c9d310d99bb12f9b/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)install.julialang.org/usr/bin/curl curl -fsSL REDACTED(dns block)julialang-s3.julialang.org/usr/bin/curl curl -I REDACTED(dns block)pkg.julialang.org/usr/bin/julia julia --project -e using Pkg; Pkg.test()(dns block)append!(empty!(Base.DL_LOAD_PATH), String[])
cd("/home/REDACTED/work/ExplicitImports.jl/ExplicitImports.jl/test")
ap` (dns block)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.