This repository was archived by the owner on May 4, 2019. It is now read-only.
Conversation
Member
|
Probably better merge the changes you finished first even if tests don't pass, and leave problematic files out for now? |
Member
|
Can we just let this package die with 1.0 with a clear note in the README? |
Member
|
Given that Jacob ported a lot of the code, I'd rather merge that. Then we'll see whether somebody is interested in doing the rest of the port or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, this is as far as I got for 1.0 compat here. The reducedim.jl and broadcast.jl changes are way more involved.