Allow hashing DataArrays with NA values#154
Conversation
|
This seems like a good strategy. I'm confused why the old approach wouldn't have worked, though -- it seems like it should just be too slow. |
|
For me on v0.4 the old code was throwing |
|
I'm going to hold off merging for a bit to give others a chance to review, but the CI failure seems unrelated and this seems good to go. |
|
I've just thought it might be better to use |
|
Sounds good. I would do some profiling to make sure that it's worth the effort; for the almost no-NA case I imagine it will be meaningfully slower to use |
|
OK, I've replaced the PR with the |
Without this
DataFrames.nonunique()and friends do not work on frames with NA rows.