Refactor filtering arguments in DFG functions to use 'whereNoun'#1215
Merged
Refactor filtering arguments in DFG functions to use 'whereNoun'#1215
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors DFG listing/filtering APIs to use where*-prefixed keyword arguments (e.g. whereLabel, whereTags) to improve discoverability/autocomplete and make call sites read more naturally.
Changes:
- Renamed filter keyword arguments across core list/find/state/blobentry APIs to
where*variants. - Updated GraphsDFG implementations and related helpers (
ls,lsf,getSubgraph,getBiadjacencyMatrix, blobentry accessors) to pass through the new keywords. - Updated tests and NEWS entry to reflect the renamed API.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/testBlocks.jl | Updates test call sites from *Filter keywords to where*. |
| test/iifInterfaceTests.jl | Updates interface tests to use where* filters. |
| src/services/list.jl | Updates ls/lsf keyword API to where* and forwards to list*. |
| src/services/find.jl | Updates findVariablesNearTimestamp filtering kwargs to where*. |
| src/services/DFGVariable.jl | Updates listStates filtering kwargs to whereLabel / whereVariableLabel. |
| src/services/Bloblet.jl | Updates TODO comment to reflect new whereLabel naming. |
| src/services/AbstractDFG.jl | Updates docstrings and getSubgraph/getBiadjacencyMatrix internals to where*; updates filter examples. |
| src/GraphsDFG/services/GraphsDFG.jl | Renames filtering kwargs for GraphsDFG CRUD/listing/neighborhood APIs to where*. |
| src/Deprecated.jl | Renames filter kwargs used by deprecated helpers to where*. |
| src/DataBlobs/services/BlobEntry.jl | Renames blobentry filtering kwargs to whereLabel/whereBlobid. |
| NEWS.md | Documents the breaking keyword rename to where*. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Affie
commented
Apr 1, 2026
Affie
commented
Apr 1, 2026
Affie
commented
Apr 1, 2026
Co-authored-by: Johannes Terblanche <6612981+Affie@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1215 +/- ##
========================================
Coverage 79.97% 79.97%
========================================
Files 37 37
Lines 2522 2522
========================================
Hits 2017 2017
Misses 505 505 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons:
listVariables(fg, whereLabel = startswith("x"))list variables where its label starts with "x"