Skip to content

Refactor path functions to findPath[s]#1214

Merged
Affie merged 4 commits intodevelopfrom
refac/path
Mar 26, 2026
Merged

Refactor path functions to findPath[s]#1214
Affie merged 4 commits intodevelopfrom
refac/path

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented Mar 24, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces new path-finding APIs (getPath / getPaths) for navigating factor graphs, refactors older path-related helpers toward those APIs, and adds test coverage for common pathfinding scenarios and filter combinations.

Changes:

  • Add getPaths / getPath to the AbstractDFG API surface (as declared services) and implement them using Graphs.jl algorithms in the GraphsDFG backend.
  • Deprecate/redirect legacy path utilities (findShortestPathDijkstra, findFactorsBetweenNaive) toward the new APIs.
  • Add a dedicated “Path Finding” testset covering shortest path, k-shortest paths, and filtering behavior (labels/solvable/tags).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/services/AbstractDFG.jl Declares getPaths / getPath services; adjusts subgraph convenience wrapper naming.
src/GraphsDFG/services/GraphsDFG.jl Implements getPaths (A*, Yen) and getPath, plus subgraph restriction support.
src/GraphsDFG/GraphsDFG.jl Imports the new path APIs for extension within the GraphsDFG module.
src/DistributedFactorGraphs.jl Marks getPath / getPaths as unstable API functions.
src/Deprecated.jl Refactors legacy path utilities to deprecate/redirect to getPath[s].
test/testBlocks.jl Adds PathFindingTests covering multiple graph/path/filter scenarios.
test/interfaceTests.jl Adds a "Path Finding" testset invoking PathFindingTests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 65.45455% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.97%. Comparing base (5f896ed) to head (295e6c2).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/Deprecated.jl 0.00% 16 Missing ⚠️
src/GraphsDFG/services/GraphsDFG.jl 91.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1214      +/-   ##
===========================================
+ Coverage    79.16%   79.97%   +0.80%     
===========================================
  Files           37       37              
  Lines         2506     2522      +16     
===========================================
+ Hits          1984     2017      +33     
+ Misses         522      505      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Affie Affie changed the title Refactor path functions to getPath[s] Refactor path functions to findPath[s] Mar 26, 2026
@Affie Affie merged commit cf1e85e into develop Mar 26, 2026
5 of 6 checks passed
@Affie Affie deleted the refac/path branch March 26, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants