New version: SpeedyWeather v0.17.5

[JuliaRegistrator]

• Registering package: SpeedyWeather
• Repository: https://github.com/SpeedyWeather/SpeedyWeather.jl
• Created by: @bgroenks96
• Version: v0.17.5
• Commit: e1c3cb41705e4abd3384058c85aff38ae5b28cec
• Reviewed by: @bgroenks96
• Reference: SpeedyWeather/SpeedyWeather.jl@e1c3cb4#commitcomment-183619913
• Description: Play atmospheric modelling like it's LEGO.
• Release notes:

- Fix broken SpeedyWeatherInternals compat #1070

[bgroenks96]

Do not merge yet

[github-actions]

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines which are not met ❌

• Could not obtain tree hash from commit hash and subdir parameter. Possibly this indicates that an incorrect subdir parameter was passed during registration.

2. Needs action: here's what to do next

1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

[juliasloan25]

It looks like this PR modifies S/SpeedyWeather/Package.toml‎, which isn't listed in the files it's allowed to change, by removing the subdir field. The subdir was added in SpeedyWeather v0.18 via this manual PR and the release PR.

I'm not sure how changes to the Package.toml should be handled for a backport release. We don't want to remove the subdir for current/future versions of SpeedyWeather, but we do want to remove it for the backport.

@milankl @giordano do you have any ideas?

[giordano]

I guess it happened because the backport branch is before the move of the package to a subdirectory. Not really sure whether this would cause problems.

[noblock]

[bgroenks96]

Wait, I'm confused; if the subdir was manually added to Package.toml which is global to all versions, how does installing v0.17.x versions work at all currently? Shouldn't that fail?

[noblock]

[giordano]

how does installing v0.17.x versions work at all currently? Shouldn't that fail?

I honestly have little clue of how the subdir works in Pkg.

Moving to the subdir also in the v0.17 branch, if doable, would definitely solve many issues.

[noblock]

[GunnarFarneback]

[noblock]

Wait, I'm confused; if the subdir was manually added to Package.toml which is global to all versions, how does installing v0.17.x versions work at all currently? Shouldn't that fail?

Installation of registered versions are solely based on the tree hash information (content hashes) and does not care about subdir at all. The latter is important when you e.g. add at a git revision like the v0.17.0 tag:

(jl_3pmOTk) pkg> add SpeedyWeather#v0.17.0
ERROR: Did not find subdirectory `SpeedyWeather`

(Notice that this is very different from installing the corresponding registered version with add SpeedyWeather@0.17.0.)

[github-actions]

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. It would also be helpful if you could post a message in the #pkg-registration channel of the JuliaLang Slack (https://julialang.org/slack/), to increase visibility. [noblock]

[bgroenks96]

[noblock]

@maximillian-gelbrecht and @milankl What should we do about this PR?

@juliasloan25 Is this still relevant for you? Or has the Clima code been updated to a newer version?

[milankl]

[noblock]

I don't know how to solve this problem with a backport pre-monorepo times. If there's a good solution I'm all ears. I thought the main branch of JuliaRegistries/General was regularly stored somehow so that a release of a backport version is just like adding that version's toml to a list of possible versions, not affecting newer ones. If that was the case we could mess as we like with the subdir as long as we revert it for the next no-backport release, e.g. v0.21. But I'm not sure about this and not keen to break things for more recent releases of SpeedyWeather