Better way to handle #457 (#474)

Author: jverzani

src/common.jl

@@ -638,11 +638,7 @@ has a nonzero coefficient. The degree of the zero polynomial is defined to be -1
 """
 degree(p::AbstractPolynomial) = iszero(coeffs(p)) ? -1 : length(coeffs(p)) - 1 + min(0, minimumexponent(p))
 
-function order(p::AbstractPolynomial)
-    Base.depwarn("The `order` function is deprecated. Use `degree`.",
-                 :AbstractPolynomial)
-    degree(p)
-end
+@deprecate order degree false
 
 
 """

test/ChebyshevT.jl

@@ -10,6 +10,7 @@
         @test p.coeffs == coeff
         @test coeffs(p) == coeff
         @test degree(p) == length(coeff) - 1
+        @test (@test_deprecated Polynomials.order(p)) == length(coeff) - 1 # issue 457
         @test Polynomials.indeterminate(p) == :x
         @test length(p) == length(coeff)
         @test size(p) == size(coeff)

test/StandardBasis.jl

@@ -66,6 +66,9 @@ isimmutable(::Type{<:ImmutablePolynomial}) = true
             ## issue 464
             @variable z
             @test z^2 + 2 == Polynomial([2,0,1], :z)
+
+            ## issue 457
+            @test (@test_deprecated Polynomials.order(p)) == length(coeff) - 1
         end
     end
 end
@@ -146,15 +149,10 @@ Base.getindex(z::ZVector, I::Int) = parent(z)[I + z.offset]
         @test degree(Polynomials.basis(P,5)) == 5
         @test Polynomials.isconstant(P(1))
         @test !Polynomials.isconstant(variable(P))
-    end
 
-    ## issue #457
-    if VERSION >= v"1.7.0"
-        p = Polynomial([1,2,3])
-        @test_warn "deprecated" Polynomials.order(p)
-        @test Polynomials.order(p) == 2
     end
 
+
 end
 
 @testset "Non-number type" begin