change deprecation to avoid export (#473)

* change deprecation to avoid export

* rework testing

* avoid failure on 1.6

Author: jverzani

Project.toml

@@ -2,7 +2,7 @@ name = "Polynomials"
 uuid = "f27b6e38-b328-58d1-80ce-0feddd5e7a45"
 license = "MIT"
 author = "JuliaMath"
-version = "3.2.4"
+version = "3.2.5"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/common.jl

@@ -638,7 +638,12 @@ has a nonzero coefficient. The degree of the zero polynomial is defined to be -1
 """
 degree(p::AbstractPolynomial) = iszero(coeffs(p)) ? -1 : length(coeffs(p)) - 1 + min(0, minimumexponent(p))
 
-@deprecate order degree true
+function order(p::AbstractPolynomial)
+    Base.depwarn("The `order` function is deprecated. Use `degree`.",
+                 :AbstractPolynomial)
+    degree(p)
+end
+
 
 """
     Polynomials.domain(::Type{<:AbstractPolynomial})

test/ChebyshevT.jl

@@ -10,7 +10,6 @@
         @test p.coeffs == coeff
         @test coeffs(p) == coeff
         @test degree(p) == length(coeff) - 1
-        @test (@test_deprecated order(p)) == length(coeff) - 1
         @test Polynomials.indeterminate(p) == :x
         @test length(p) == length(coeff)
         @test size(p) == size(coeff)

test/StandardBasis.jl

@@ -147,6 +147,14 @@ Base.getindex(z::ZVector, I::Int) = parent(z)[I + z.offset]
         @test Polynomials.isconstant(P(1))
         @test !Polynomials.isconstant(variable(P))
     end
+
+    ## issue #457
+    if VERSION >= v"1.7.0"
+        p = Polynomial([1,2,3])
+        @test_warn "deprecated" Polynomials.order(p)
+        @test Polynomials.order(p) == 2
+    end
+
 end
 
 @testset "Non-number type" begin