Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## mt-015 #123 +/- ##
=======================================
Coverage 55.55% 55.55%
=======================================
Files 42 42
Lines 1179 1179
=======================================
Hits 655 655
Misses 524 524
☔ View full report in Codecov by Sentry. |
Collaborator
|
I have this in #122 already, I think - if it's ok I'd hold off until that done (hopefully very soon) to reduce merge conflicts. |
Collaborator
Author
|
I don't think so, the pr targets that branch |
Collaborator
Author
|
OTOH no problem waiting if you prefer, it's pretty minor I think |
Collaborator
|
Thanks - I'll get back to that monster-PR, promise! |
Collaborator
|
Included in #142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Julia 1.10 beta (at least) we get this warning a lot:
Here Simeon Schaub suggests that to address this, "Just use Vararg{Number} instead of Vararg{<:Number}". This PR makes this small change