Draft
Conversation
Contributor
|
On clear advantage: having this as artifact using Artifacts means it does not download directly, but it goes through the julia package server. When someone is using firewall and package server is whitelisted there, data downloaded through Artifacts go through that, so that's good, but using datadeps means it's downloading data directly, not going through the package server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The download is not lazy at the moment, I don't understand how to lazily download multiple files.
Even if that is fixed, I don't see a clear advantage over current DataDeps implementation so not sure this is worth doing