Skip to content

[codex] Tighten versions.json schema constraints #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DilumAluthge-LLM wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

[codex] Tighten versions.json schema constraints #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
17775c0
Add schema validation CI job
DilumAluthge-LLM May 1, 2026
1e0e593
Add portable URL constraints to schema
DilumAluthge-LLM May 1, 2026
8fa0c68
Add sha256 schema pattern
DilumAluthge-LLM May 2, 2026
9e862e5
Add git-tree-sha1 schema pattern
DilumAluthge-LLM May 2, 2026
2e0db2a
Add git-tree-sha256 schema pattern
DilumAluthge-LLM May 2, 2026
6a0b230
Add version schema pattern
DilumAluthge-LLM May 2, 2026
88df3cf
Add top-level version key pattern
DilumAluthge-LLM May 2, 2026
285affb
Add asc PGP armor schema pattern
DilumAluthge-LLM May 2, 2026
2d60af0
Require nonempty asc values
DilumAluthge-LLM May 2, 2026
2738e95
Require tar.gz URL suffixes
DilumAluthge-LLM May 2, 2026
626c8a9
Require nonempty HTTPS URL hosts
DilumAluthge-LLM May 2, 2026
63117c6
Reject whitespace in URLs
DilumAluthge-LLM May 2, 2026
020f8af
Require URL filename basenames
DilumAluthge-LLM May 2, 2026
4c995fc
Update URL extension metadata for tar.gz
DilumAluthge-LLM May 2, 2026
41ba1f8
Require positive file sizes
DilumAluthge-LLM May 2, 2026
56b4b59
Require version entries to list files
DilumAluthge-LLM May 2, 2026
1beb522
Require at least one version entry
DilumAluthge-LLM May 2, 2026
d908299
Require unique file entries
DilumAluthge-LLM May 2, 2026
a936a10
Require extension to match URL suffix
DilumAluthge-LLM May 2, 2026
03192c2
Require kind to match extension
DilumAluthge-LLM May 2, 2026
42c5e8f
Require triplet to match OS
DilumAluthge-LLM May 2, 2026
6c88b05
Require triplet to match architecture
DilumAluthge-LLM May 2, 2026
03e509a
Require prereleases to be unstable
DilumAluthge-LLM May 2, 2026
8efeb3f
Require plain releases to be stable
DilumAluthge-LLM May 2, 2026
c89aeb6
Validate current S3 versions.json against schema
DilumAluthge-LLM May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,16 @@ jobs:
path: versions.json
if-no-files-found: error

schema-check:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # 6.0.2

- run: npx -p ajv-cli@3.3.0 ajv compile -s schema.json

upload-to-s3:
needs: [package-tests, full-test]
needs: [package-tests, full-test, schema-check]
if: github.event_name == 'workflow_dispatch' && github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
timeout-minutes: 60
Expand Down Expand Up @@ -141,5 +149,7 @@ jobs:
run: rm -fv versions.json
- name: Download the current versions.json from S3
run: curl -LO https://julialang-s3.julialang.org/bin/versions.json
- name: Validate versions.json against schema
run: npx -p ajv-cli@3.3.0 ajv -s schema.json -d versions.json
- name: Run the post-build tests on the versions.json that we downloaded from S3
run: julia --project test/more_tests.jl versions.json
259 changes: 252 additions & 7 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,34 @@
{
"$schema": "http://json-schema.org/draft-06/schema#",
"type": "object",
"minProperties": 1,
"propertyNames": {
"pattern": "^[0-9]+\\.[0-9]+\\.[0-9]+(?:-(?:alpha[0-9]*|beta[0-9]*|rc[0-9]+|pre\\.(?:alpha|beta)))?$"
},
"allOf": [
{
"patternProperties": {
"^[0-9]+\\.[0-9]+\\.[0-9]+-(?:alpha[0-9]*|beta[0-9]*|rc[0-9]+|pre\\.(?:alpha|beta))$": {
"properties": {
"stable": {
"const": false
}
}
}
}
},
{
"patternProperties": {
"^[0-9]+\\.[0-9]+\\.[0-9]+$": {
"properties": {
"stable": {
"const": true
}
}
}
}
}
],
"additionalProperties": {
"$ref": "#/definitions/WelcomeValue"
},
Expand All @@ -11,6 +39,8 @@
"properties": {
"files": {
"type": "array",
"minItems": 1,
"uniqueItems": true,
"items": {
"$ref": "#/definitions/File"
}
Expand Down Expand Up @@ -39,19 +69,24 @@
"$ref": "#/definitions/Arch"
},
"sha256": {
"type": "string"
"type": "string",
"pattern": "^[0-9A-Fa-f]{64}$"
},
"git-tree-sha1": {
"type": "string"
"type": "string",
"pattern": "^[0-9A-Fa-f]{40}$"
},
"git-tree-sha256": {
"type": "string"
"type": "string",
"pattern": "^[0-9A-Fa-f]{64}$"
},
"size": {
"type": "integer"
"type": "integer",
"minimum": 1
},
"version": {
"type": "string"
"type": "string",
"pattern": "^[0-9]+\\.[0-9]+\\.[0-9]+(?:-(?:alpha[0-9]*|beta[0-9]*|rc[0-9]+|pre\\.(?:alpha|beta)))?$"
},
"os": {
"$ref": "#/definitions/OS"
Expand All @@ -65,12 +100,25 @@
"qt-uri-extensions": [
".dmg",
".exe",
".gz",
".tar.gz",
".zip"
],
"allOf": [
{
"pattern": "^https://[^/?#]+/"
},
{
"pattern": "^https://\\S+$"
},
{
"pattern": "/[^/?#]+\\.(?:dmg|exe|tar\\.gz|zip)$"
}
]
},
"asc": {
"type": "string"
"type": "string",
"minLength": 1,
"pattern": "^-----BEGIN PGP SIGNATURE-----\\n(?:[A-Za-z0-9-]+: [^\\n]*\\n)*\\n(?:[A-Za-z0-9+/]{1,76}=*\\n)+=[A-Za-z0-9+/]{4}\\n-----END PGP SIGNATURE-----\\n?$"
},
"extension": {
"$ref": "#/definitions/FileExtension"
Expand All @@ -87,6 +135,203 @@
"url",
"version"
],
"allOf": [
{
"anyOf": [
{
"properties": {
"extension": {
"const": "dmg"
},
"url": {
"pattern": "\\.dmg$"
}
}
},
{
"properties": {
"extension": {
"const": "exe"
},
"url": {
"pattern": "\\.exe$"
}
}
},
{
"properties": {
"extension": {
"const": "tar.gz"
},
"url": {
"pattern": "\\.tar\\.gz$"
}
}
},
{
"properties": {
"extension": {
"const": "zip"
},
"url": {
"pattern": "\\.zip$"
}
}
}
]
},
{
"anyOf": [
{
"properties": {
"kind": {
"const": "installer"
},
"extension": {
"const": "exe"
}
}
},
{
"properties": {
"kind": {
"const": "archive"
},
"extension": {
"enum": [
"dmg",
"tar.gz",
"zip"
]
}
}
}
]
},
{
"anyOf": [
{
"properties": {
"os": {
"const": "mac"
},
"triplet": {
"enum": [
"x86_64-apple-darwin14",
"aarch64-apple-darwin14"
]
}
}
},
{
"properties": {
"os": {
"const": "winnt"
},
"triplet": {
"enum": [
"x86_64-w64-mingw32",
"i686-w64-mingw32"
]
}
}
},
{
"properties": {
"os": {
"const": "linux"
},
"triplet": {
"enum": [
"x86_64-linux-gnu",
"i686-linux-gnu",
"powerpc64le-linux-gnu",
"aarch64-linux-gnu",
"armv7l-linux-gnueabihf",
"x86_64-linux-musl"
]
}
}
},
{
"properties": {
"os": {
"const": "freebsd"
},
"triplet": {
"const": "x86_64-unknown-freebsd11.1"
}
}
}
]
},
{
"anyOf": [
{
"properties": {
"arch": {
"const": "x86_64"
},
"triplet": {
"enum": [
"x86_64-apple-darwin14",
"x86_64-w64-mingw32",
"x86_64-linux-gnu",
"x86_64-unknown-freebsd11.1",
"x86_64-linux-musl"
]
}
}
},
{
"properties": {
"arch": {
"const": "i686"
},
"triplet": {
"enum": [
"i686-w64-mingw32",
"i686-linux-gnu"
]
}
}
},
{
"properties": {
"arch": {
"const": "powerpc64le"
},
"triplet": {
"const": "powerpc64le-linux-gnu"
}
}
},
{
"properties": {
"arch": {
"const": "aarch64"
},
"triplet": {
"enum": [
"aarch64-linux-gnu",
"aarch64-apple-darwin14"
]
}
}
},
{
"properties": {
"arch": {
"const": "armv7l"
},
"triplet": {
"const": "armv7l-linux-gnueabihf"
}
}
}
]
}
],
"title": "File"
},
"Arch": {
Expand Down
Loading