Backports to release 1.12.4 #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dkarrasch
commented
Dec 16, 2025
dkarrasch
commented
- Fix GEMM dispatch for complex-real matmul #1520
- Make sure inputs to the hemm etc tests are Hermitian #1522
This should fix #1519. The issue on master is that we have specialized dispatches for arrays of the same eltype, and the complex-real matmul ends up in `generic_matmatmul!`. This adds an extra method to ensure that the complex-real case also reaches BLAS. ```julia julia> A = ones(ComplexF64, 400, 400); B = ones(size(A)); C = similar(A); julia> @Btime mul!($C, $A, $B); 57.043 ms (0 allocations: 0 bytes) # master 1.608 ms (0 allocations: 0 bytes) # this PR ```
Fix #1496 JuliaLinearAlgebra/AppleAccelerate.jl#87 Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #1524 +/- ##
================================================
+ Coverage 93.63% 93.70% +0.06%
================================================
Files 34 34
Lines 15481 15477 -4
================================================
+ Hits 14495 14502 +7
+ Misses 986 975 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.