change highlight color from an RGB value to Base.error_color()#74
change highlight color from an RGB value to Base.error_color()#74KristofferC wants to merge 1 commit intomainfrom
Base.error_color()#74Conversation
|
Yeah
I used RGB to satisfy my own desire for things to be pretty and to have sane mappings to color codes. But for general use we'll need something widely supported 👍 Unfortunately So we "just" need to figure out what's generally supported and do that. Can we use 255 colors for example, or do we need to limit ourselves to 16? Is reverse color better supported than background colors? |
RGB colors have very spotty support in terminals so probably better to use something more well-supported.
Base.error_color()is by default:light_redbut can also be customized with an env var.Ref #61
Edit: Okay I see there is this whole machinery for using RGBs so I guess this was a conscious choice. Waiting with this until there is a decision on what to do.