Collect all JSON Schema validation issues#83
Draft
quinnj wants to merge 2 commits into
Draft
Conversation
Add a fail_fast keyword to validate so callers can collect every validation issue in a single pass while preserving the existing first-failure default. Fixes #38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate(...; fail_fast = false)to collect validation issues in one passSingleIssueornothingallOf, and conditionalif/thenvalidationRoot Cause
The validator was structured as a recursive first-failure walk. Nested validators returned immediately after the first
SingleIssue, so sibling fields likeTitleandDesccould not both be reported from one validation call.Validation
julia --project=. -e 'using Pkg; Pkg.test()'git diff --checkFixes #38
Co-authored by Codex