Fix typed dictionary ref resolution#82
Open
quinnj wants to merge 1 commit into
Open
Conversation
Copy Base Dict schema inputs into Dict{K,Any} before resolving refs so strictly typed nested dictionaries can hold resolved schema objects. Keep parsed JSON objects on the existing deepcopy path to preserve current behavior.
Fixes #81
quinnj
force-pushed
the
codex/fix-typed-ref-resolution
branch
from
50c4742 to
c66eb0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dictschema inputs into widenedDict{K,Any}containers before resolving refs.Dictschema containers on the existingdeepcopypath.$refs fails ifDictis strictly typed #81 covering a strictly typed nested dictionary and ensuring the caller's input remains unchanged.Root Cause
Schema(::AbstractDict)deep-copied user input without widening nestedDictvalue types. During$refexpansion, the resolver replaces a string ref with the referenced schema dictionary, which fails for nested dictionaries inferred asDict{String,String}.Fixes #81
Validation
julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'Co-authored by Codex