Switch Excel support to XLSX.jl

[TimG1964]

I will need to make a new release of XLSX.jl for this, but would prefer to know the version of FileIO.jl needed for compats. XLSX.jl is ready to go - you can inspect it here if you wish.

Will resolve #428.

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.09%. Comparing base (3c40adc) to head (72d5be7).
⚠️ Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
src/registry.jl	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   91.17%   91.09%   -0.08%     
==========================================
  Files          11       11              
  Lines         714      719       +5     
==========================================
+ Hits          651      655       +4     
- Misses         63       64       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[TimG1964]

Had to add magic bytes as well as extensions to get over ambiguity with NPZ.

[TimG1964]

As with #124, "There is a bit of a chicken and egg situation here": the tests in XLSX.jl can only pass once this here is merged and tagged, but this here obviously only works if the extension to XLSX.jl is merged and tagged.

I've put the XLSX.jl tests inside a version check on FileIO.jl, but it would be good to know which tagged version of FileIO.jl is (or will be) the first that supports XLSX.jl. I can then tag a new release.

[SimonDanisch]

Yeah, I also haven't found a patented solution for this...
You could manually depend on this branch in CI while its not tagged, or manually register in init or in the tests...
I guess the best solution would be to only change test code and not have it in init or so, so that the switch can be done cleanly.

[TimG1964]

I've tested on my own fork, so I know tests pass. I just don't want to tag a release until I know what version of FileIO will eventually work.

In my runtests.jl file, I have

if Pkg.pkgversion(FileIO) > v"1.19.0"
    @testset "FileIO" verbose=true begin
            # do the tests
    end
else
    @info "Skipping FileIO tests (requires FileIO > v1.19.0, got $(pkgversion(FileIO)))"
end

So it is just a question of knowing the version to use in the condition. I can tag a release as soon as I know this for certain.

[TimG1964]

Just in case I'm confused, I think I'm waiting for you, @SimonDanisch, to confirm a FileIO release version that will make the switch from ExcelFiles to XLSX (per this PR). I will immediately insert that version number into my code and make a new release of XLSX to support.

Have I got this back to front? Are you waiting for me to do something (what?) or am I just too impatient?

[SimonDanisch]

Ah sorry, lots to do... Well I guess with the next version?

[TimG1964]

Hi @SimonDanisch, I have just now merged an XLSX.jl PR that (among other things) now supports FileIO.jl. I've restructured the docs to make support for FileIO easily visible. But, of course, this is all dead code until FileIO.jl updates, merging this PR to use XLSX.jl.

I'd like to tag a new version of XLSX.jl but I'd prefer to wait until FileIO is updated. Would you mind doing this, please?

Thanks!