Skip to content

feat: Refactor IGraph to parametric type and extend API support for Graphs.jl integration (#446)#42

Closed
mahmudsudo wants to merge 6 commits intoJuliaGraphs:masterfrom
mahmudsudo:master
Closed

feat: Refactor IGraph to parametric type and extend API support for Graphs.jl integration (#446)#42
mahmudsudo wants to merge 6 commits intoJuliaGraphs:masterfrom
mahmudsudo:master

Conversation

@mahmudsudo
Copy link
Copy Markdown

This PR refactors the core IGraph type to be parametric and extends the API support to satisfy the requirements for full Graphs.jl integration (as part of issue #446).

@Krastanov
Copy link
Copy Markdown
Member

Thanks! This seems like a good start, but did you actually run the tests? It seems they fail universally.

This should probably be split in 3 separate PRs to help with review and with testing -- (1) interface tests, (2) parametric type, (3) Graphs.jl API

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 30.11364% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.04%. Comparing base (f5aad57) to head (fab6261).

Files with missing lines Patch % Lines
src/graph_api_extensions.jl 0.00% 68 Missing ⚠️
src/graph_api.jl 39.77% 53 Missing ⚠️
src/types.jl 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master     #42      +/-   ##
=========================================
- Coverage    5.28%   4.04%   -1.25%     
=========================================
  Files           8       8              
  Lines        4311    4523     +212     
=========================================
- Hits          228     183      -45     
- Misses       4083    4340     +257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov
Copy link
Copy Markdown
Member

Do not worry about the missing parts of the CI -- if you decide to add those, make sure to do these contributions in separate PRs, so that they can be reviewed independently

@mahmudsudo
Copy link
Copy Markdown
Author

mahmudsudo commented Mar 27, 2026

Do not worry about the missing parts of the CI -- if you decide to add those, make sure to do these contributions in separate PRs, so that they can be reviewed independently

by the seperate prs , do you mean the second pr on graphs.jl ?

@Krastanov
Copy link
Copy Markdown
Member

No, I mean that here in a single PR you have made many unrelated changes. That makes the review slower as one needs to handle many different concerns at the same time. The idea is that 5 small PRs can be reviewed and merged very quickly, while one big PR that has the content of all 5 is much slower to review.

mahmudsudo added a commit to mahmudsudo/IGraphs.jl that referenced this pull request Mar 28, 2026
@mahmudsudo
Copy link
Copy Markdown
Author

the splitted prs are #43 #44 #45

@Krastanov
Copy link
Copy Markdown
Member

closing as we are now looking at the split PRs

@Krastanov Krastanov closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants