Add algorithms for distance-regular graphs#405
Draft
pddshk wants to merge 6 commits intoJuliaGraphs:masterfrom
Draft
Add algorithms for distance-regular graphs#405pddshk wants to merge 6 commits intoJuliaGraphs:masterfrom
pddshk wants to merge 6 commits intoJuliaGraphs:masterfrom
Conversation
added 6 commits
October 21, 2024 01:34
gdalle
requested changes
Nov 21, 2024
Member
There was a problem hiding this comment.
Hi, thank you for this contribution and sorry for the delay!
I think these are useful functions, but before I review in detail, could you maybe:
- choose more specific names for
global_parametersand perhapsintersection_array(perhaps prefix them withdistance_regular) - test all the functions you introduce, including on cases where they return false
- whenever possible, avoid math in the docstrings (it doesn't display well in the REPL), replace the double backticks with single backticks and leverage unicode instead
Thanks in advance!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namely:
Wikipedia reference
NetworkX reference