Metal: turn device-exception traps into returns to avoid GPU hangs#810
Merged
Conversation
On Apple GPUs a compute `trap` wedges the whole device (no compute watchdog; only a reboot clears it), so device-side exceptions hung the GPU on macOS 15+. Run `replace_unreachable!` unconditionally and have it strip the preceding `llvm.trap` and synthesize a return when a function only contains `unreachable`. See JuliaGPU/Metal.jl#433. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member
Author
|
CI failures unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Apple GPUs a compute
trapwedges the whole device (no compute watchdog; only a reboot clears it), so device-side exceptions hung the GPU on macOS 15+. Runreplace_unreachable!unconditionally and have it strip the precedingllvm.trapand synthesize a return when a function only containsunreachable.Fixes JuliaGPU/Metal.jl#433.