Skip to content

Adjust broken test predicate so 1.13 test pass#775

Merged
maleadt merged 1 commit intomasterfrom
beta3
Mar 22, 2026
Merged

Adjust broken test predicate so 1.13 test pass#775
maleadt merged 1 commit intomasterfrom
beta3

Conversation

@christiangnrd
Copy link
Member

Previously broken test now fixed on 1.13 beta 3

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/native/precompile.jl b/test/native/precompile.jl
index b96fb0a..3f0eff4 100644
--- a/test/native/precompile.jl
+++ b/test/native/precompile.jl
@@ -76,7 +76,7 @@ precompile_test_harness("Inference caching") do load_path
         @test check_presence(square_mi, token)
 
         # check that identity survived
-        @test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || v"1.13.0-" <= VERSION < v"1.13.0-beta3")
+        @test check_presence(identity_mi, token) broken = (v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || v"1.13.0-" <= VERSION < v"1.13.0-beta3")
 
         GPUCompiler.clear_disk_cache!()
         @test GPUCompiler.disk_cache_enabled() == false
diff --git a/test/ptx/precompile.jl b/test/ptx/precompile.jl
index 1b4e2d7..8054479 100644
--- a/test/ptx/precompile.jl
+++ b/test/ptx/precompile.jl
@@ -49,6 +49,6 @@ precompile_test_harness("Inference caching") do load_path
         @test check_presence(kernel_mi, token)
 
         # check that identity survived
-        @test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || v"1.13.0-" <= VERSION < v"1.13.0-beta3")
+        @test check_presence(identity_mi, token) broken = (v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || v"1.13.0-" <= VERSION < v"1.13.0-beta3")
     end
 end

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.79%. Comparing base (719d92e) to head (40acce0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   74.55%   74.79%   +0.23%     
==========================================
  Files          24       24              
  Lines        3781     3781              
==========================================
+ Hits         2819     2828       +9     
+ Misses        962      953       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt maleadt merged commit 12cbca4 into master Mar 22, 2026
32 of 38 checks passed
@maleadt maleadt deleted the beta3 branch March 22, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants