Skip to content

Default to the job's optimize parameter in code_llvm #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christiangnrd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Default to the job's optimize parameter in code_llvm #773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/reflection.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ struct jl_llvmf_dump
end

"""
code_llvm([io], job; optimize=true, raw=false, dump_module=false)
code_llvm([io], job; optimize=job.config.optimize, raw=false, dump_module=false)

Prints the device LLVM IR generated for the given compiler job to `io` (default `stdout`).

Expand All @@ -183,7 +183,7 @@ The following keyword arguments are supported:

See also: [`@device_code_llvm`](@ref), `InteractiveUtils.code_llvm`
"""
function code_llvm(io::IO, @nospecialize(job::CompilerJob); optimize::Bool=true, raw::Bool=false,
function code_llvm(io::IO, @nospecialize(job::CompilerJob); optimize::Bool=job.config.optimize, raw::Bool=false,
debuginfo::Symbol=:default, dump_module::Bool=false, kwargs...)
# NOTE: jl_dump_function_ir supports stripping metadata, so don't do it in the driver
config = CompilerConfig(job.config; validate=false, strip=false, optimize)
Expand Down Expand Up @@ -383,7 +383,7 @@ macro device_code(ex...)
end

open(joinpath(dir, "$fn.opt.ll"), "w") do io
code_llvm(io, job; dump_module=true, raw=true)
code_llvm(io, job; dump_module=true, raw=true, optimize=true)
end

open(joinpath(dir, "$fn.asm"), "w") do io
Expand Down
Loading