Allow sorting arrays of more than 2^30 elements#65
Open
pawel-tarasiuk-quantumz wants to merge 1 commit intoJuliaGPU:mainfrom
Open
Allow sorting arrays of more than 2^30 elements#65pawel-tarasiuk-quantumz wants to merge 1 commit intoJuliaGPU:mainfrom
pawel-tarasiuk-quantumz wants to merge 1 commit intoJuliaGPU:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows sorting arrays of more than
2^30elements.In
merge_sort.jl,half_size_groupis currently converted toInt32. As a result, sorting arrays with more than2^30elements raises aDivideError.The expected behavior is that arrays should be sortable up to the limits of available memory.
Proposed fix skips the
Int32conversion when the number of elements exceeds2^30.MWE (works with proposed changes):
Current result: