Fix SciMLStyle regressions#979
Open
svchb wants to merge 10 commits intoJuliaEditorSupport:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #978
Regressions fixed
Indexed assignment LHS splitting
Fixed indexed assignment targets being split even when the full index expression fits on one line.
Before:
cache_table[key, slot] = source_table[key, slot] + step * delta_table[key, slot]After:
Pair RHS call forced onto a new line
Fixed pair entries where the => RHS call was moved to a new continuation line unnecessarily.
Before:
After:
Multiline typed pair vectors collapsed
Fixed multiline typed pair-vector literals being collapsed into a single long line.
Before:
After:
Tuple bindings in threaded for headers
Fixed tuple bindings in for headers being split across lines even when they fit.
Before:
After:
Multiline do block arguments
Fixed calls with keyword arguments followed by do blocks where the closing parenthesis was moved to its own line and do arguments were realigned incorrectly.
Before:
After:
Dict entries with tuple RHS values
Fixed Dict(...) entries with tuple RHS values so pair arrows align consistently and RHS tuple contents remain in SciML-style layout.
Before:
After:
Comments inside multiline tuple RHS values
Fixed comments inside multiline tuple RHS values being shifted left after formatting.
Before:
After:
Short binary expressions inside tuple RHS values
Fixed short RHS expressions staying split even though the flattened expression fits within the SciML margin.
Before:
After: